use http_build_query for query string creation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

austinpray wants to merge 1 commit into ScreenshotsCloud:master from oncarrot:http_build_query

austinpray commented Nov 14, 2019

Use https://www.php.net/manual/en/function.http-build-query.php to build the query string

well defined behavior
benefits from updates and bug fixes to PHP in the future
simplifies the source

what's not to love?


          use http_build_query for query string creation

56bc0a5

Contributor

Bantam commented Nov 16, 2019

Thanks Austin, we'll test this and look towards merging next week!

Author

austinpray commented Nov 11, 2020

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet