Bundle private/public keys in one flat archive

[aaaaalbert]

Feedback from the SAS 2018 Sensibility Hackathon: The Custom Installer Builder creates new key pairs for users if you don't upload public keys for them. After the Build step, three separate downloads are offered:

• An archive containing all private keys (if any),
• An archive containing all public keys, including those that were uploaded,
• And finally, the customized installers themselves.

Also, the keys archives each contain and thus extract into a directory, public_keys/ and private_keys/, respectively. Navigating these dirs to just copy over the keys to a demokit dir has been described as "a pain", particularly on Windows.

A suggested solution is to,

1. Put all keys / key pairs into a single archive (to avoid handling multiple archives)
2. Make the archive "flat", i.e. not contain a subdirectory (so that its contents will extract right into the dir that the archive is placed in)

The place to modify is this bit in packager.py. We'll need to check that the workflow where pubkeys are uploaded keeps working, as our Clearinghouses depend on it.

@yyzhuang, @JustinCappos, let me hear what you think.

[JustinCappos]

Yes, please do.

…

On Tue, Mar 27, 2018 at 5:02 AM, aaaaalbert ***@***.***> wrote: Feedback from the SAS 2018 Sensibility Hackathon: The Custom Installer Builder creates new key pairs for users if you don't upload public keys for them. After the *Build* step, three separate downloads are offered: - An archive containing all private keys (if any), - An archive containing all public keys, including those that were uploaded, - And finally, the customized installers themselves. Also, the keys archives each contain and thus extract into a directory, public_keys/ and private_keys/, respectively. Navigating these dirs to just copy over the keys to a demokit dir has been described as "a pain", particularly on Windows. A suggested solution is to, 1. Put all keys / key pairs into a single archive (to avoid handling multiple archives) 2. Make the archive "flat", i.e. not contain a subdirectory (so that its contents will extract right into the dir that the archive is placed in) The place to modify is this bit in packager.py <https://github.com/SeattleTestbed/custominstallerbuilder/blob/0e1573ae0211f4a506745cc591071a908b39e59a/common/packager.py#L167-L224>. We'll need to check that the workflow where pubkeys are uploaded keeps working, as our Clearinghouses depend on it. @yyzhuang <https://github.com/yyzhuang>, @JustinCappos <https://github.com/JustinCappos>, let me hear what you think. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#22>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA0XD3rN9H2Xxi00nogSHxCVG1hGJDTsks5tigA7gaJpZM4S8i9l> .

[yyzhuang]

Please go ahead and make the changes, also making sure that uploading keys won't break. Thanks.

[aaaaalbert]

One observation from my initial tests: OS X will always extract archives that contain more than one file into a sub-directory of the current working dir. This is still mildly painfull, but at least you can loadkeys keys/username in seash which works as long as the public and private keys are in the same dir.

[JustinCappos]

This would be fine. It saves many steps of downloading, separately unpacking, and copying files. Justin

…

On Wed, Mar 28, 2018 at 7:43 AM, aaaaalbert ***@***.***> wrote: One observation from my initial tests: OS X will always extract archives that contain more than one file into a sub-directory of the current working dir. This is still mildly painfull, but at least you can loadkeys keys/username in seash which works as long as the public and private keys are in the same dir. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#22 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA0XD9Q6MXKFdu-w3RNTRL1ggMhnGDLnks5ti3dmgaJpZM4S8i9l> .

[aaaaalbert]

Alright, here's a running prototype for you to test: https://seattle-dev.engineering.nyu.edu/cib/

Please use (and try to break) it in any way conceivable --- different browsers and OSses, Private tabs and plain ones, all combinations of public keys and CIB-created users, whatever you can think of ---, and provide feedback below.

Also feel free to review the suggested patch, aaaaalbert/custominstallerbuilder@64787d0.