fixed mypy errors

Author: sandeepsuryaprasad

py/selenium/webdriver/common/bidi/browser.py

@@ -15,10 +15,12 @@
 # specific language governing permissions and limitations
 # under the License.
 
+
 import warnings
-from typing import Optional
+from typing import Any, Optional
 
 from selenium.webdriver.common.bidi.common import command_builder
+from selenium.webdriver.common.bidi.session import UserPromptHandler
 from selenium.webdriver.common.proxy import Proxy
 
 
@@ -243,7 +245,7 @@ def y(self, value) -> None:
         self._y = value
 
     @property
-    def active(self):
+    def active(self) -> bool:
         """Gets the Window Status.
 
         Returns:
@@ -269,6 +271,7 @@ def is_active(self) -> bool:
         -------
             bool: True if the client window is active, False otherwise.
         """
+        warnings.warn("is_active method is deprecated, use `active` property instead", DeprecationWarning, stacklevel=2)
         return self.active
 
     @classmethod
@@ -284,13 +287,13 @@ def from_dict(cls, data: dict) -> "ClientWindowInfo":
             ClientWindowInfo: A new instance of ClientWindowInfo.
         """
         return cls(
-            client_window=data.get("clientWindow"),
-            state=data.get("state"),
-            width=data.get("width"),
-            height=data.get("height"),
-            x=data.get("x"),
-            y=data.get("y"),
-            active=data.get("active"),
+            client_window=data["clientWindow"],
+            state=data["state"],
+            width=data["width"],
+            height=data["height"],
+            x=data["x"],
+            y=data["y"],
+            active=data["active"],
         )
 
 
@@ -300,26 +303,35 @@ class Browser:
     def __init__(self, conn):
         self.conn = conn
 
-    def create_user_context(self, accept_insecure_certs: Optional[bool] = None, proxy: Optional[Proxy] = None) -> str:
+    def create_user_context(
+        self,
+        accept_insecure_certs: Optional[bool] = None,
+        proxy: Optional[Proxy] = None,
+        unhandled_prompt_behavior: Optional[UserPromptHandler] = None,
+    ) -> str:
         """Creates a new user context.
 
         Parameters:
         -----------
             accept_insecure_certs: Optional flag to accept insecure TLS certificates
             proxy: Optional proxy configuration for the user context
+            unhandled_prompt_behavior: Optional configuration for handling user prompts
 
         Returns:
         -------
             str: The ID of the created user context.
         """
-        params = {}
+        params: dict[str, Any] = {}
 
         if accept_insecure_certs is not None:
             params["acceptInsecureCerts"] = accept_insecure_certs
 
         if proxy is not None:
             params["proxy"] = proxy.to_bidi_dict()
 
+        if unhandled_prompt_behavior is not None:
+            params["unhandledPromptBehavior"] = unhandled_prompt_behavior.to_dict()
+
         result = self.conn.execute(command_builder("browser.createUserContext", params))
         return result["userContext"]
 

py/test/selenium/webdriver/common/bidi_browser_tests.py

@@ -22,6 +22,7 @@
 import pytest
 
 from selenium.webdriver.common.bidi.browser import ClientWindowInfo, ClientWindowState
+from selenium.webdriver.common.bidi.session import UserPromptHandler, UserPromptHandlerType
 from selenium.webdriver.common.by import By
 from selenium.webdriver.common.proxy import Proxy, ProxyType
 from selenium.webdriver.common.utils import free_port
@@ -235,3 +236,29 @@ def test_create_user_context_with_proxy_and_accept_insecure_certs(driver):
         driver.browser.remove_user_context(user_context)
         fake_proxy_server.shutdown()
         fake_proxy_server.server_close()
+
+
+def test_create_user_context_with_unhandled_prompt_behavior(driver, pages):
+    """Test creating a user context with unhandled prompt behavior configuration."""
+    prompt_handler = UserPromptHandler(
+        alert=UserPromptHandlerType.DISMISS, default=UserPromptHandlerType.DISMISS, prompt=UserPromptHandlerType.DISMISS
+    )
+
+    user_context = driver.browser.create_user_context(unhandled_prompt_behavior=prompt_handler)
+    assert user_context is not None
+
+    # create a new browsing context with the user context
+    bc = driver.browsing_context.create(type=WindowTypes.WINDOW, user_context=user_context)
+    assert bc is not None
+
+    driver.switch_to.window(bc)
+    pages.load("alerts.html")
+
+    # TODO: trigger an alert and test that it is dismissed automatically, currently not working,
+    #  conftest.py unhandled_prompt_behavior set to IGNORE, see if it is related
+    # driver.find_element(By.ID, "alert").click()
+    # # accessing title should be possible since alert is auto handled
+    # assert driver.title == "Testing Alerts"
+
+    # Clean up
+    driver.browser.remove_user_context(user_context)