Merge pull request #217 from adamsitnik/master

mythz · mythz · commit c65020b07f64 · 2015-10-30T08:37:36.000-04:00
performance: create list with predefined size to avoid unnecessary GC
diff --git a/src/ServiceStack.Redis/UtilExtensions.cs b/src/ServiceStack.Redis/UtilExtensions.cs
@@ -1,16 +1,13 @@
-﻿using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
+﻿using System.Collections.Generic;
 using ServiceStack.Text;
 
 namespace ServiceStack.Redis
 {
 	internal static class UtilExtensions
 	{
-		public static List<T> ConvertEachTo<T>(this IEnumerable<string> list)
+		public static List<T> ConvertEachTo<T>(this List<string> list)
 		{
-			var to = new List<T>();
+			var to = new List<T>(list.Count);
 			foreach (var item in list)
 			{
 				to.Add(JsonSerializer.DeserializeFromString<T>(item));

Original file line number	Diff line number	Diff line change
`@@ -1,16 +1,13 @@`
`1`		`-using System;`
`2`		`-using System.Collections.Generic;`
`3`		`-using System.Linq;`
`4`		`-using System.Text;`
	`1`	`+using System.Collections.Generic;`
`5`	`2`	`using ServiceStack.Text;`
`6`	`3`
`7`	`4`	`namespace ServiceStack.Redis`
`8`	`5`	`{`
`9`	`6`	`internal static class UtilExtensions`
`10`	`7`	`{`
`11`		`- public static List<T> ConvertEachTo<T>(this IEnumerable<string> list)`
	`8`	`+ public static List<T> ConvertEachTo<T>(this List<string> list)`
`12`	`9`	`{`
`13`		`- var to = new List<T>();`
	`10`	`+ var to = new List<T>(list.Count);`
`14`	`11`	`foreach (var item in list)`
`15`	`12`	`{`
`16`	`13`	`to.Add(JsonSerializer.DeserializeFromString<T>(item));`