Merge pull request #2075 from Shopify/fix-primaryAction-on-Page

Fixing type on primaryAction

Author: dleroux

UNRELEASED.md

@@ -7,3 +7,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f
 ### Documentation
 
 - Fixed paths to images in the “Attention badge” example
+
+### Bug fixes
+
+- Fixed the page component's primary action to support `LoadableAction`s and `DisableableAction`s

src/components/Page/types.ts

@@ -1,9 +1,10 @@
 import {
   ActionListItemDescriptor,
-  BaseAction,
   IconableAction,
   DisableableAction,
   BadgeAction,
+  LoadableAction,
+  DestructableAction,
 } from '../../types';
 import {PaginationDescriptor} from '../Pagination';
 import {Props as BreadcrumbProps} from '../Breadcrumbs';
@@ -36,11 +37,12 @@ export interface ActionProps {
   hasIndicator?: boolean;
 }
 
-export interface PrimaryActionProps extends BaseAction {
+export interface PrimaryActionProps
+  extends DisableableAction,
+    LoadableAction,
+    DestructableAction {
   /** Provides extra visual weight and identifies the primary action in a set of buttons */
   primary?: boolean;
-  /** Indicates a dangerous or potentially negative action */
-  destructive?: boolean;
 }
 
 export interface HeaderProps {