Skip to content

Conversation

@TheLimeGlass
Copy link
Contributor

@TheLimeGlass TheLimeGlass commented Jul 23, 2025

Problem

VisualEffect doesn't use the Particle registry.

Solution

Adds Particle registry, so when Spigot or Paper removes enum from Particle to be a proper registry, it'll be automatic.

@TheLimeGlass TheLimeGlass requested a review from a team as a code owner July 23, 2025 19:36
@TheLimeGlass TheLimeGlass requested review from Burbulinis and Efnilite and removed request for a team July 23, 2025 19:36
@TheLimeGlass TheLimeGlass force-pushed the feature/particle-registry branch from eeb0c1c to 7da7dda Compare July 23, 2025 19:49
@TheLimeGlass
Copy link
Contributor Author

Current branch building is broken. Waiting until that gets fixed outside this pull request

    failed to parse tag looping (        loop the tag contents of minecraft item tag "logs" and             add loop-item to {_list::*} (as java.lang.Object)) (Expected <none>, but got         loop the tag contents of minecraft item tag "logs" and             add loop-item to {_list::*} (as java.lang.Object)) [ExprTagContents.sk, line 12] (on paper-1.21.7)
  type hints (on 1 environment)
    Hint failed (        set {_x} (as java.lang.Object) to [[long:10]] and Expected variable '{_x}' to be a text, but it is an integer) (Expected a value equal to Expected variable '{_x}' to be a text, but it is an integer, but got         set {_x} (as java.lang.Object) to [[long:10]] and Expected variable '{_x}' to be a text, but it is an integer) [type hints.sk, line 11] (on paper-1.21.7)
  worldborder damage amount (on 1 environment)
    Adding NaN damage value did not throw error [ExprWorldBorderDamageAmount.sk, line 40] (on paper-1.21.7)

@TheLimeGlass TheLimeGlass marked this pull request as draft July 23, 2025 20:00
@APickledWalrus
Copy link
Member

Current branch building is broken. Waiting until that gets fixed outside this pull request

Just want to note that the only issues from this PR are:
image

For some reason, it is not identifying the existing effects properly. Maybe the keys aren't aligning with what's in the lang files.

@TheLimeGlass
Copy link
Contributor Author

TODO make the VisualEffectType also support non Enum in the constructor for future changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants