Skip to content

Commit 26d24f4

Browse files
authored
Merge pull request #553 from SolidOS/styleStreamline
Style streamline
2 parents f40cba9 + 9860a9c commit 26d24f4

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/tabs.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ export function tabWidget (options: TabWidgetOptions) {
182182
const rootElement: TabWidgetElement = dom.createElement('div') // 20200117a
183183

184184
rootElement.setAttribute('style', style.tabsRootElement)
185-
rootElement.style.flexDirection = (vertical ? 'row' : 'column') + (flipped ? '-reverse;' : ';')
185+
rootElement.style.flexDirection = (vertical ? 'row' : 'column') + (flipped ? '-reverse' : '')
186186

187187
const navElement = rootElement.appendChild(dom.createElement('nav'))
188188
navElement.setAttribute('style', style.tabsNavElement)

test/unit/tabs.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -178,22 +178,22 @@ describe('tabWidget', () => {
178178
})
179179
it('positions tabs on top by default', () => {
180180
tabWidgetElement = tabs.tabWidget(minimalOptions)
181-
expect(tabWidgetElement.style['flex-direction']).toEqual('column;')
181+
expect(tabWidgetElement.style['flex-direction']).toEqual('column')
182182
})
183183

184184
it('can position tabs on right', () => {
185185
tabWidgetElement = tabs.tabWidget({ orientation: '1', ...minimalOptions })
186-
expect(tabWidgetElement.style['flex-direction']).toEqual('row;')
186+
expect(tabWidgetElement.style['flex-direction']).toEqual('row')
187187
})
188188

189189
it('can position tabs on bottom', () => {
190190
tabWidgetElement = tabs.tabWidget({ orientation: '2', ...minimalOptions })
191-
expect(tabWidgetElement.style['flex-direction']).toEqual('column-reverse;')
191+
expect(tabWidgetElement.style['flex-direction']).toEqual('column-reverse')
192192
})
193193

194194
it('can position tabs on left', () => {
195195
tabWidgetElement = tabs.tabWidget({ orientation: '3', ...minimalOptions })
196-
expect(tabWidgetElement.style['flex-direction']).toEqual('row-reverse;')
196+
expect(tabWidgetElement.style['flex-direction']).toEqual('row-reverse')
197197
})
198198
})
199199

0 commit comments

Comments
 (0)