Skip to content

Commit e30d874

Browse files
author
AimeeKnight
committed
FAD-460 #time 15m fix boolean logic for open and click tracking
1 parent 211aea9 commit e30d874

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/transmission.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ var toApiFormat = function(input) {
2727
model.metadata = input.metadata;
2828
model.substitution_data = input.substitutionData;
2929

30-
model.options.open_tracking = input.trackOpens || true;
31-
model.options.click_tracking = input.trackClicks || true;
30+
model.options.open_tracking = input.trackOpens === false ? false : true;
31+
model.options.click_tracking = input.trackClicks === false ? false : true;
3232

3333
model.content.use_draft_template = input.useDraftTemplate || false;
3434
model.content.reply_to = input.replyTo;

test/spec/transmissions.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ describe('Transmissions Library', function() {
5757

5858
it('should allow a user to override open and click tracking', function() {
5959
transmission.send({trackOpens: false, trackClicks: false}, function(err, res) {
60-
expect(sendSpy.args[0][0].json.options.open_tracking).to.be.true;
61-
expect(sendSpy.args[0][0].json.options.click_tracking).to.be.true;
60+
expect(sendSpy.args[0][0].json.options.open_tracking).to.be.false;
61+
expect(sendSpy.args[0][0].json.options.click_tracking).to.be.false;
6262
});
6363
});
6464

0 commit comments

Comments
 (0)