Bump to latest lints (#417)

kevmoo · web-flow · commit 137871baa8cf · 2025-04-15T08:59:25.000-06:00
Bump to latest lints, require Dart 3.5
diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml
@@ -13,7 +13,7 @@ jobs:
       matrix:
         os: [ubuntu-latest]
         # Test with at least the declared minimum Dart version
-        sdk: ['3.1', stable]
+        sdk: ['3.5', stable]
     steps:
       - uses: actions/checkout@v4
       - uses: dart-lang/setup-dart@v1
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,6 @@
 ## 9.25.0-wip
 
-* Require Dart 3.1
+* Require Dart 3.5
 * Require `package:http` `^1.0.0`.
 
 ## 9.24.0
diff --git a/example/common.dart b/example/common.dart
@@ -1,4 +1,5 @@
 import 'dart:async';
+// ignore: deprecated_member_use
 import 'dart:html';
 
 import 'package:github/github.dart';
@@ -13,7 +14,6 @@ export 'package:github/github.dart';
 Future<void> initViewSourceButton(String script) async {
   // query the DOM for the view source button, handle clicks
   document.querySelector('#view-source')?.onClick.listen((_) {
-    // ignore: unsafe_html
     final popup = window.open(
         'https://github.com/SpinlockLabs/github.dart/blob/master/example/$script',
         'View Source');
diff --git a/example/emoji.dart b/example/emoji.dart
@@ -1,4 +1,5 @@
 import 'dart:async';
+// ignore: deprecated_member_use
 import 'dart:html';
 
 import 'common.dart';
diff --git a/example/index.dart b/example/index.dart
@@ -1,4 +1,6 @@
+// ignore: deprecated_member_use
 import 'dart:html';
+
 import 'common.dart';
 
 void main() {
diff --git a/example/languages.dart b/example/languages.dart
@@ -1,3 +1,4 @@
+// ignore: deprecated_member_use
 import 'dart:html';
 
 import 'common.dart';
@@ -34,7 +35,6 @@ void reloadTable({int accuracy = 4}) {
   isReloadingTable = true;
   final md = generateMarkdown(accuracy);
   github.misc.renderMarkdown(md).then((html) {
-    // ignore: unsafe_html
     tableDiv!.setInnerHtml(html, treeSanitizer: NodeTreeSanitizer.trusted);
     isReloadingTable = false;
   });
diff --git a/example/organization.dart b/example/organization.dart
@@ -1,4 +1,5 @@
 import 'dart:async';
+// ignore: deprecated_member_use
 import 'dart:html';
 
 import 'common.dart';
diff --git a/example/pr.dart b/example/pr.dart
@@ -1,4 +1,5 @@
 import 'dart:async';
+// ignore: deprecated_member_use
 import 'dart:html';
 
 import 'common.dart';
diff --git a/example/readme.dart b/example/readme.dart
@@ -1,3 +1,4 @@
+// ignore: deprecated_member_use
 import 'dart:html';
 
 import 'common.dart';
diff --git a/example/release_notes.dart b/example/release_notes.dart
@@ -1,3 +1,4 @@
+// ignore: deprecated_member_use
 import 'dart:html';
 
 import 'package:pub_semver/pub_semver.dart';
diff --git a/example/releases.dart b/example/releases.dart
@@ -1,3 +1,4 @@
+// ignore: deprecated_member_use
 import 'dart:html';
 
 import 'common.dart';
diff --git a/example/repos.dart b/example/repos.dart
@@ -1,4 +1,5 @@
 import 'dart:async';
+// ignore: deprecated_member_use
 import 'dart:html';
 
 import 'common.dart';
diff --git a/example/search.dart b/example/search.dart
@@ -1,4 +1,6 @@
+// ignore: deprecated_member_use
 import 'dart:html';
+
 import 'common.dart';
 
 Future<void> main() async {
diff --git a/example/stars.dart b/example/stars.dart
@@ -1,3 +1,4 @@
+// ignore: deprecated_member_use
 import 'dart:html';
 
 import 'common.dart';
diff --git a/example/user_info.dart b/example/user_info.dart
@@ -1,3 +1,4 @@
+// ignore: deprecated_member_use
 import 'dart:html';
 
 import 'common.dart';
diff --git a/example/users.dart b/example/users.dart
@@ -1,4 +1,5 @@
 import 'dart:async';
+// ignore: deprecated_member_use
 import 'dart:html';
 
 import 'common.dart';
diff --git a/example/zen.dart b/example/zen.dart
@@ -1,4 +1,6 @@
+// ignore: deprecated_member_use
 import 'dart:html';
+
 import 'common.dart';
 
 Future<void> main() async {
diff --git a/lib/browser_helper.dart b/lib/browser_helper.dart
@@ -1,4 +1,6 @@
+// ignore: deprecated_member_use
 import 'dart:html';
+
 import 'package:github/src/common.dart';
 
 ///  Renders Markdown in HTML using the GitHub API
@@ -24,7 +26,6 @@ void renderMarkdown(GitHub github, String selector, {int indent = 4}) {
       e.hidden = false;
       e.setAttribute('rendered', '');
       e.classes.add('markdown-body');
-      // ignore: unsafe_html
       e.setInnerHtml(html, treeSanitizer: NodeTreeSanitizer.trusted);
     });
   }
diff --git a/lib/hooks.dart b/lib/hooks.dart
@@ -7,7 +7,6 @@
 /// Add this import if you are in a non-web environment and writing something
 /// that uses github hooks. For more information, see github hooks documentation
 /// https://developer.github.com/v3/repos/hooks/
-
-library hooks;
+library;
 
 export 'src/server/xplat_server.dart';
diff --git a/lib/src/browser/xplat_browser.dart b/lib/src/browser/xplat_browser.dart
@@ -1,4 +1,6 @@
+// ignore: deprecated_member_use
 import 'dart:html';
+
 import 'package:github/src/common.dart';
 import 'package:github/src/common/xplat_common.dart'
     show findAuthenticationInMap;
diff --git a/lib/src/common/activity_service.dart b/lib/src/common/activity_service.dart
@@ -329,7 +329,7 @@ class EventPoller {
   final List<String?> handledEvents = [];
 
   Timer? _timer;
-  StreamController<Event>? _controller; // ignore: close_sinks
+  StreamController<Event>? _controller;
 
   String? _lastFetched;
 
diff --git a/lib/src/common/github.dart b/lib/src/common/github.dart
@@ -190,7 +190,7 @@ class GitHub {
   ///
   /// The future will pass the object returned from this function to the then method.
   /// The default [convert] function returns the input object.
-  /// [body] is the data to send to the server. Pass in a List<int> if you want to post binary body data. Everything else will have .toString() called on it and set as text content
+  /// [body] is the data to send to the server. Pass in a `List<int>` if you want to post binary body data. Everything else will have .toString() called on it and set as text content
   /// [S] represents the input type.
   /// [T] represents the type return from this function after conversion
   Future<T> postJSON<S, T>(
@@ -232,7 +232,7 @@ class GitHub {
   ///
   /// The future will pass the object returned from this function to the then method.
   /// The default [convert] function returns the input object.
-  /// [body] is the data to send to the server. Pass in a List<int> if you want to post binary body data. Everything else will have .toString() called on it and set as text content
+  /// [body] is the data to send to the server. Pass in a `List<int>` if you want to post binary body data. Everything else will have .toString() called on it and set as text content
   /// [S] represents the input type.
   /// [T] represents the type return from this function after conversion
   Future<T> putJSON<S, T>(
@@ -274,7 +274,7 @@ class GitHub {
   ///
   /// The future will pass the object returned from this function to the then method.
   /// The default [convert] function returns the input object.
-  /// [body] is the data to send to the server. Pass in a List<int> if you want to post binary body data. Everything else will have .toString() called on it and set as text content
+  /// [body] is the data to send to the server. Pass in a `List<int>` if you want to post binary body data. Everything else will have .toString() called on it and set as text content
   /// [S] represents the input type.
   /// [T] represents the type return from this function after conversion
   Future<T> patchJSON<S, T>(
@@ -343,7 +343,7 @@ class GitHub {
   /// [path] can either be a path like '/repos' or a full url.
   /// [headers] are HTTP Headers. If it doesn't exist, the 'Accept' and 'Authorization' headers are added.
   /// [params] are query string parameters.
-  /// [body] is the body content of requests that take content. Pass in a List<int> if you want to post binary body data. Everything else will have .toString() called on it and set as text content
+  /// [body] is the body content of requests that take content. Pass in a `List<int>` if you want to post binary body data. Everything else will have .toString() called on it and set as text content
   ///
   Future<http.Response> request(
     String method,
diff --git a/lib/src/common/util/pagination.dart b/lib/src/common/util/pagination.dart
@@ -31,7 +31,6 @@ class PaginationHelper {
     var page = params['page'] ?? 1;
     params['page'] = page;
 
-    // ignore: literal_only_boolean_expressions
     while (true) {
       http.Response response;
       try {
diff --git a/pubspec.yaml b/pubspec.yaml
@@ -4,7 +4,7 @@ description: A high-level GitHub API Client Library that uses Github's v3 API
 homepage: https://github.com/SpinlockLabs/github.dart
 
 environment:
-  sdk: ^3.1.0
+  sdk: ^3.5.0
 
 dependencies:
   http: ^1.0.0
@@ -19,7 +19,7 @@ dev_dependencies:
   collection: ^1.15.0
   dependency_validator: ^3.0.0
   json_serializable: ^6.6.1
-  lints: ^4.0.0
+  lints: ^5.0.0
   mockito: ^5.3.2
   nock: ^1.1.3
   pub_semver: ^2.0.0
diff --git a/test/unit/orgs_service_test.dart b/test/unit/orgs_service_test.dart
@@ -93,7 +93,6 @@ void main() {
       final github = GitHub(client: client);
       final organizationsService = OrganizationsService(github);
 
-      // ignore: omit_local_variable_types
       expect(
           () async => organizationsService.getTeamByName(
               'flutter', 'flutter-programmers'),

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`import 'dart:async';`
	`2`	`+// ignore: deprecated_member_use`
`2`	`3`	`import 'dart:html';`
`3`	`4`
`4`	`5`	`import 'common.dart';`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+// ignore: deprecated_member_use`
`1`	`2`	`import 'dart:html';`
`2`	`3`
`3`	`4`	`import 'common.dart';`