Add BHI6660 to rules declared by several BizHawk.Analyzer.*Analyzer

YoshiRulz · YoshiRulz · commit aaefdeaadca6 · 2025-07-13T17:10:46.000+10:00
will rebuild in later commit
diff --git a/ExternalProjects/BizHawk.Analyzer/DefineCheckedOpAnalyzer.cs b/ExternalProjects/BizHawk.Analyzer/DefineCheckedOpAnalyzer.cs
@@ -32,7 +32,7 @@ public sealed class DefineCheckedOpAnalyzer : DiagnosticAnalyzer
 	};
 
 	public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; }
-		= ImmutableArray.Create(/*HawkSourceAnalyzer.DiagWTF,*/ DiagDefineCheckedOp);
+		= ImmutableArray.Create(HawkSourceAnalyzer.DiagWTF, DiagDefineCheckedOp);
 
 	public override void Initialize(AnalysisContext context)
 	{
diff --git a/ExternalProjects/BizHawk.Analyzer/ExprBodiedMemberFlowAnalyzer.cs b/ExternalProjects/BizHawk.Analyzer/ExprBodiedMemberFlowAnalyzer.cs
@@ -15,7 +15,7 @@ public sealed class ExprBodiedMemberFlowAnalyzer : DiagnosticAnalyzer
 		isEnabledByDefault: true);
 
 	public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; }
-		= ImmutableArray.Create(/*HawkSourceAnalyzer.DiagWTF,*/ DiagExprBodiedMemberFlow);
+		= ImmutableArray.Create(HawkSourceAnalyzer.DiagWTF, DiagExprBodiedMemberFlow);
 
 	public override void Initialize(AnalysisContext context)
 	{
diff --git a/ExternalProjects/BizHawk.Analyzer/FirstOrDefaultOnStructAnalyzer.cs b/ExternalProjects/BizHawk.Analyzer/FirstOrDefaultOnStructAnalyzer.cs
@@ -15,7 +15,7 @@ public sealed class FirstOrDefaultOnStructAnalyzer : DiagnosticAnalyzer
 		isEnabledByDefault: true);
 
 	public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; }
-		= ImmutableArray.Create(/*HawkSourceAnalyzer.DiagWTF,*/ DiagUseFirstOrNull);
+		= ImmutableArray.Create(HawkSourceAnalyzer.DiagWTF, DiagUseFirstOrNull);
 
 	public override void Initialize(AnalysisContext context)
 	{
diff --git a/ExternalProjects/BizHawk.Analyzer/NoTargetTypedThrowAnalyzer.cs b/ExternalProjects/BizHawk.Analyzer/NoTargetTypedThrowAnalyzer.cs
@@ -14,7 +14,7 @@ public sealed class NoTargetTypedThrowAnalyzer : DiagnosticAnalyzer
 		isEnabledByDefault: true);
 
 	public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; }
-		= ImmutableArray.Create(/*HawkSourceAnalyzer.DiagWTF,*/ DiagNoTargetTypedThrow);
+		= ImmutableArray.Create(HawkSourceAnalyzer.DiagWTF, DiagNoTargetTypedThrow);
 
 	public override void Initialize(AnalysisContext context)
 	{
diff --git a/ExternalProjects/BizHawk.Analyzer/UseSimplerBoolFlipAnalyzer.cs b/ExternalProjects/BizHawk.Analyzer/UseSimplerBoolFlipAnalyzer.cs
@@ -19,7 +19,7 @@ public sealed class UseSimplerBoolFlipAnalyzer : DiagnosticAnalyzer
 		isEnabledByDefault: true);
 
 	public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; }
-		= ImmutableArray.Create(/*HawkSourceAnalyzer.DiagWTF,*/ DiagUseSimplerBoolFlip);
+		= ImmutableArray.Create(HawkSourceAnalyzer.DiagWTF, DiagUseSimplerBoolFlip);
 
 	public override void Initialize(AnalysisContext context)
 	{

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public sealed class DefineCheckedOpAnalyzer : DiagnosticAnalyzer`
`32`	`32`	`};`
`33`	`33`
`34`	`34`	`public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; }`
`35`		`- = ImmutableArray.Create(/HawkSourceAnalyzer.DiagWTF,/ DiagDefineCheckedOp);`
	`35`	`+ = ImmutableArray.Create(HawkSourceAnalyzer.DiagWTF, DiagDefineCheckedOp);`
`36`	`36`
`37`	`37`	`public override void Initialize(AnalysisContext context)`
`38`	`38`	`{`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ public sealed class ExprBodiedMemberFlowAnalyzer : DiagnosticAnalyzer`
`15`	`15`	`isEnabledByDefault: true);`
`16`	`16`
`17`	`17`	`public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; }`
`18`		`- = ImmutableArray.Create(/HawkSourceAnalyzer.DiagWTF,/ DiagExprBodiedMemberFlow);`
	`18`	`+ = ImmutableArray.Create(HawkSourceAnalyzer.DiagWTF, DiagExprBodiedMemberFlow);`
`19`	`19`
`20`	`20`	`public override void Initialize(AnalysisContext context)`
`21`	`21`	`{`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ public sealed class FirstOrDefaultOnStructAnalyzer : DiagnosticAnalyzer`
`15`	`15`	`isEnabledByDefault: true);`
`16`	`16`
`17`	`17`	`public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; }`
`18`		`- = ImmutableArray.Create(/HawkSourceAnalyzer.DiagWTF,/ DiagUseFirstOrNull);`
	`18`	`+ = ImmutableArray.Create(HawkSourceAnalyzer.DiagWTF, DiagUseFirstOrNull);`
`19`	`19`
`20`	`20`	`public override void Initialize(AnalysisContext context)`
`21`	`21`	`{`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ public sealed class NoTargetTypedThrowAnalyzer : DiagnosticAnalyzer`
`14`	`14`	`isEnabledByDefault: true);`
`15`	`15`
`16`	`16`	`public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; }`
`17`		`- = ImmutableArray.Create(/HawkSourceAnalyzer.DiagWTF,/ DiagNoTargetTypedThrow);`
	`17`	`+ = ImmutableArray.Create(HawkSourceAnalyzer.DiagWTF, DiagNoTargetTypedThrow);`
`18`	`18`
`19`	`19`	`public override void Initialize(AnalysisContext context)`
`20`	`20`	`{`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ public sealed class UseSimplerBoolFlipAnalyzer : DiagnosticAnalyzer`
`19`	`19`	`isEnabledByDefault: true);`
`20`	`20`
`21`	`21`	`public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; }`
`22`		`- = ImmutableArray.Create(/HawkSourceAnalyzer.DiagWTF,/ DiagUseSimplerBoolFlip);`
	`22`	`+ = ImmutableArray.Create(HawkSourceAnalyzer.DiagWTF, DiagUseSimplerBoolFlip);`
`23`	`23`
`24`	`24`	`public override void Initialize(AnalysisContext context)`
`25`	`25`	`{`