Doris_core directory not compiling due to error in function declaration in orbitbk.hh #27
Description
Hello, as stated in the title the Doris core directory won't compile after using the configure executable; this appears to be due the fact that during the definition of some friend functions in the orbitbk.hh file (namely the coordinates change ones) they are given fixed values for some arguments (such as MAXITER and CRITTERTIM or CRITTERPOS). I tried changing the code and the only thing that made compiling possible was not giving the friend functions their fixed arguments but at the same time re-defining out of the orbit class in the same header file the same functions, no longer as friend ones, with fixed arguments, as shown here: https://stackoverflow.com/questions/22533511/friend-declaration-specifying-a-default-argument-must-be-a-definition This made compiling possible but causes segmentation fault with sigsev. This issue seems to be present both in the version 4 and 5 of Doris. See attached files for what exactly was shown on my terminal. I'm using currently a macbook pro late 2013 15" with the latest version of MacOs Big Sur at the time (11.2.3) and with Xcode 12D4e version.
