-
-
Notifications
You must be signed in to change notification settings - Fork 427
feat: code syntax highlighting #1226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TrigamDev
wants to merge
35
commits into
TagStudioDev:main
Choose a base branch
from
TrigamDev:feat/code-syntax-highlighting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: code syntax highlighting #1226
TrigamDev
wants to merge
35
commits into
TagStudioDev:main
from
TrigamDev:feat/code-syntax-highlighting
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cluded in the name list
…ghlighting' into feat/code-syntax-highlighting
# Conflicts: # pyproject.toml # src/tagstudio/qt/previews/renderer.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Blocked
This issue or pull request is awaiting the outcome of another issue or pull request
Status: Review Needed
A review of this is needed
Thumbs/Previews
File thumbnails or previews
Type: Enhancement
New feature or request
Type: QoL
A quality of life (QoL) enhancement or suggestion
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the thumbnail display for plaintext files with a new
TextDisplaywidget, which supports syntax highlighting.The syntax highlighting style is configurable, with
GitHub Darkbeing the default.Notes:
superqt'sCodeSyntaxHighlightutility is used to provide syntax highlighting to theQTextEditwidget thatTextDisplayis based on. The syntax highlighting itself and all of the styles are provided bypygments.CodeSyntaxHighlightcould be made to reduce the number of dependencies. This was just a quick way to get something working. Plus,superqt's widgets could potentially prove useful.Tasks Completed