Failed tests from data_structures::probabilistic::count_min_sketch::tests::must_not_underestimate_count

[WinterPancake]

After running "cargo test" in nightly I got the error code saying that it failed a test from data_structures::probabilistic::count_min_sketch::tests::must_not_underestimate_count
I have attached a file containing the entire error code message.

count_min_sketch.txt

[mas192]

@WinterPancake

I forked the repo and setup my local env with nightly.
I ran the cargo test as well as cargo test must_not_understimate_count
In both cases the tests passed for me.

There is a chance the issue might have been resolved by updates to the nightly.

I suggest that this issue #899 can be closed if no else can replicate it.

[WinterPancake]

@mas192 I had ran cargo test dozens of times before and after the test that I linked had failed all in the span of around an hour and they all passed but this one. I don't think the test failed due to some issue that had been resolved by updated in nightly since I had not updated nightly within the hour I had been testing.

[mas192]

@WinterPancake
Since the test don't fail for me and it fails only for you. Let's see if someone else can replicate it. If not this issue is local to your environment.

[WinterPancake]

@mas192 All tests since this fail have been passing. It seems that the issue is coming from exact_ratio being <= 0.7 from test function must_not_understimate_count. Due to us running a for loop through HashCountMinSketch<String, 50, 10> and running .get_count(), which uses hashers from RandomState to increment the count. It seems that there's a specific hash of an item that results in the inequality from the test function being false.

[github-actions]

This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[github-actions]

Please ping one of the maintainers once you add more information and updates here. If this is not the case and you need some help, feel free to ask for help in our Gitter channel. Thank you for your contributions!