Skip to content

Commit 25ba1b2

Browse files
committed
Support auto_restatement_cron in python models
1 parent 0109a3a commit 25ba1b2

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

sqlmesh/core/model/definition.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2810,6 +2810,9 @@ def render_field_value(value: t.Any) -> t.Any:
28102810
for key, value in field_value.items():
28112811
if key in RUNTIME_RENDERED_MODEL_FIELDS:
28122812
rendered_dict[key] = parse_strings_with_macro_refs(value, dialect)
2813+
elif key == "auto_restatement_cron":
2814+
# Don't parse auto_restatement_cron="@..." kwarg (e.g. @daily) into MacroVar
2815+
rendered_dict[key] = value
28132816
elif (rendered := render_field_value(value)) is not None:
28142817
rendered_dict[key] = rendered
28152818

tests/core/test_model.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2881,7 +2881,15 @@ def my_model_2(context):
28812881
# no warning with valid kind dict
28822882
with patch.object(get_console(), "log_warning") as mock_logger:
28832883

2884-
@model("kind_valid_dict", kind=dict(name=ModelKindName.FULL), columns={'"COL"': "int"})
2884+
@model(
2885+
"kind_valid_dict",
2886+
kind=dict(
2887+
name=ModelKindName.INCREMENTAL_BY_TIME_RANGE,
2888+
time_column="ds",
2889+
auto_restatement_cron="@hourly",
2890+
),
2891+
columns={'"ds"': "date", '"COL"': "int"},
2892+
)
28852893
def my_model(context):
28862894
pass
28872895

@@ -2890,7 +2898,7 @@ def my_model(context):
28902898
path=Path("."),
28912899
)
28922900

2893-
assert isinstance(python_model.kind, FullKind)
2901+
assert isinstance(python_model.kind, IncrementalByTimeRangeKind)
28942902

28952903
assert not mock_logger.call_args
28962904

0 commit comments

Comments
 (0)