ResourceApiBase#handle_error() duplicate when clause

[lifeBCE]

when RuntimeError, ArgumentError, Fog::Compute::VcloudDirector::TaskError
  #weird error format coming back from fog
  [BAD_REQUEST, error.message.split('message=>')[1]]
when RuntimeError, ArgumentError, Fog::Compute::VcloudDirector::BadRequest
  [BAD_REQUEST, error.to_s]

The above kills the intended functionality for RuntimeError and ArgumentError exceptions. The second when clause will never be reached (for these exception types) and appears to be the valid handler (for these exception types).

[huxoll]

Check with Phillip; I don't believe this fix is correct.

[lifeBCE]

Sorry, I don't understand. What is not correct? To have the same condition satisfied in two different when clauses is bad logic and the second will never be reached. If the first when clause is desired, the second should be addressed.

[huxoll]

Check with Phillip for the exact use case. We have Fog throwing an error on a successful request, so we must swallow the error to allow the UI to respond successfully.

[lifeBCE]

There might be some confusion on what I addressed. Unless Fog is throwing a RuntimeError or ArgumentError then my change should not affect whatever issues is happening with Fog. What I attempted to show in the above snippet was the duplication of RuntimeError and ArgumentError error handling. Looks like a copy and paste issue.

I'll verify with Phillip the copy and paste error I suspect here but even if Fog is throwing some weird RuntimeError or ArgumentError, this is not the way to handle it because it traps ALL RuntimeErrors or ArgumentErrors raised in any resource API. The history of the code base shows the second when clause to be the long standing original and the first is the new addition (what I believe to be the issue).

Just to be clear, there are 2 when clauses each handling 3 different exception conditions. The first two conditions in each when clause are exactly the same. The third is different and deals with Fog.

[pjschmidt3]

This should be OK to my knowledge.