Merge pull request #35 from neojski/undo-invalid-packet-slicing

codetheweb · web-flow · commit b497de0b48ea · 2019-12-21T19:03:52.000Z
Fix invalid packet slicing
diff --git a/src/lib/messenger.ts b/src/lib/messenger.ts
@@ -66,7 +66,7 @@ class Messenger extends EventEmitter {
       offset = HEADER_SIZE + 4;
     }
 
-    let payload = packet.slice(offset, offset + payloadSize - 8);
+    let payload = packet.slice(offset, HEADER_SIZE + payloadSize - 8);
 
     // Check CRC
     const expectedCrc = packet.readInt32BE(HEADER_SIZE + payloadSize - 8);

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ class Messenger extends EventEmitter {`
`66`	`66`	`offset = HEADER_SIZE + 4;`
`67`	`67`	`}`
`68`	`68`
`69`		`- let payload = packet.slice(offset, offset + payloadSize - 8);`
	`69`	`+ let payload = packet.slice(offset, HEADER_SIZE + payloadSize - 8);`
`70`	`70`
`71`	`71`	`// Check CRC`
`72`	`72`	`const expectedCrc = packet.readInt32BE(HEADER_SIZE + payloadSize - 8);`