Convert all (ancient) top scope facts

Author: vStone

manifests/server/ads.pp

@@ -24,13 +24,15 @@
   $target_ou                  = 'Nix_Mashine',
   $perform_join               = true) {
 
-  $krb5_user_package = $::osfamily ? {
+  require 'samba::server'
+
+  $krb5_user_package = $facts['os']['family'] ? {
     'RedHat' => 'krb5-workstation',
     default  => 'krb5-user',
   }
 
-  if $::osfamily == 'RedHat' {
-    if $::operatingsystemrelease =~ /^6\./ {
+  if $facts['os']['family'] == 'RedHat' {
+    if $facts['os']['release']['major'] == '6' {
       $winbind_package = 'samba-winbind'
     } else {
       $winbind_package = 'samba-common'

manifests/server/params.pp

@@ -1,12 +1,12 @@
 # == Class samba::server::params
 #
 class samba::server::params {
-  case $::osfamily {
+  case $facts['os']['family'] {
     'Redhat': { $service_name = 'smb' }
     'Debian': {
-      case $::operatingsystem {
+      case $facts['os']['name'] {
         'Debian': {
-          case $::operatingsystemmajrelease {
+          case $facts['os']['release']['major'] {
             '8' : { $service_name = 'smbd' }
             default: { $service_name = 'samba' }
           }
@@ -23,6 +23,6 @@
       $service_name = 'smbd'
       $nmbd_name = 'nmbd'
     }
-    default: { fail("${::osfamily} is not supported by this module.") }
+    default: { fail("${facts['os']['family']} is not supported by this module.") }
   }
 }