Skip to content

Commit 7c77980

Browse files
authored
fix(ui5-list): prevent toggle event bubbling from non-list items (#11843)
- Add duck-typing check in onItemToggle using isListItemBase getter - Prevents unwanted toggle events from nested components like panels Fixes #11812
1 parent aa99f55 commit 7c77980

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

packages/main/src/List.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1275,6 +1275,10 @@ class List extends UI5Element {
12751275
}
12761276

12771277
onItemToggle(e: CustomEvent<ListItemToggleEventDetail>) {
1278+
if (!(e.target as any)?.isListItemBase) {
1279+
return;
1280+
}
1281+
12781282
this.fireDecoratorEvent("item-toggle", { item: e.detail.item });
12791283
}
12801284

packages/main/src/ListItemBase.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,10 @@ class ListItemBase extends UI5Element implements ITabbable {
248248
}
249249
return this.forcedTabIndex ? parseInt(this.forcedTabIndex) : undefined;
250250
}
251+
252+
get isListItemBase() {
253+
return true;
254+
}
251255
}
252256

253257
export default ListItemBase;

0 commit comments

Comments
 (0)