Skip to content

Conversation

@Simrayz
Copy link
Contributor

@Simrayz Simrayz commented Oct 17, 2025

Scope and purpose

This PR upgrades the jQuery UI library, as part of the larger #3582 jQuery update.

How to test

Panels & Tabs

Interface Portlist

  1. Search and find an IP device
  2. Navigate to "Ports", and click on a port in the table
  3. Verify that clicking "Activity graphs" succeeds without error in the console.

Tab Navigation plugin: Location search example

A change was made to the tab_navigation plugin to use .attr('id') instead of .selector. This plugin is used by multiple views, but it should be enough to test one such usage.

  1. Find a location, e.g. "Teknobyen"
  2. Verify that clicking the tabs succeeds, and that the URL is updated with the proper hash (should be #!<tabname>

You can also verify that other views with tabs work. However, they do not update the URL has value. Affected views are:

  • Room search result, .e.g /search/room/100: Verify that tabs work
  • IP Dev Info: Verify that tabs work.
  • Syslogger: Verify that tabs work

General updates

These views have been modified to use the new jQuery UI version, but no specific changes were made to the files beyond require dependency updates.

  • Dashboard: Verify that dragging and re-ordering navlets works. Tests that the $(<selector>).droppable(...) function works.
  • Portadmin: No specific usage of jQuery UI that could break with the ugrade.
  • Thresholds > Add: Verify that the autocomplete in the Target * input field works as expected, by searching for a target and waiting for suggestions.
  • Netmap:
    • Click "View options"
    • Verify that the autocomplete in "View settings" > "Filter by room or location" works.
    • Verify that "Create new view" and "Edit view" triggers a jQuery UI dialog.
    • Verify that clicking a node in the netmap triggers a jQuery UI dialog
  • Image Upload:
    • Open either a Room or Location, e.g. /search/room/100
    • Click "Edit images"
    • Make sure that there are at least two images. Upload new images if your room/location does not have enough.
    • Verify that the images can are sortable by dragging.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • Wrote the commit message so that the first line continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • Based this pull request on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If it's not obvious from a linked issue, described how to interact with NAV in order for a reviewer to observe the effects of this change first-hand (commands, URLs, UI interactions)
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this adds a new Python source code file: Added the boilerplate header to that file

@Simrayz Simrayz self-assigned this Oct 17, 2025
@Simrayz Simrayz added javascript nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) labels Oct 17, 2025
@github-actions
Copy link

github-actions bot commented Oct 17, 2025

Test results

    27 files      27 suites   46m 11s ⏱️
 2 618 tests  2 618 ✅ 0 💤 0 ❌
19 334 runs  19 334 ✅ 0 💤 0 ❌

Results for commit ff99742.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.49%. Comparing base (332494d) to head (ff99742).
⚠️ Report is 6 commits behind head on chore/upgrade-jquery.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           chore/upgrade-jquery    #3613      +/-   ##
========================================================
- Coverage                 62.51%   62.49%   -0.02%     
========================================================
  Files                       611      611              
  Lines                     45020    45020              
  Branches                     43       43              
========================================================
- Hits                      28142    28137       -5     
- Misses                    16868    16873       +5     
  Partials                     10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Simrayz Simrayz force-pushed the chore/upgrade-jquery branch from 1784f24 to ff7a839 Compare October 17, 2025 13:06
@Simrayz Simrayz force-pushed the chore/upgrade-jquery-ui branch from fcd9641 to a750aaa Compare October 17, 2025 13:06
@Simrayz Simrayz force-pushed the chore/upgrade-jquery branch from ff7a839 to 332494d Compare October 17, 2025 13:49
@Simrayz Simrayz force-pushed the chore/upgrade-jquery-ui branch from a750aaa to ff99742 Compare October 17, 2025 13:50
@sonarqubecloud
Copy link

@Simrayz Simrayz requested a review from a team October 20, 2025 08:03
Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the easiest way to test that this works?

@hmpf
Copy link
Contributor

hmpf commented Oct 20, 2025

... and this is not correct I hope?

  • changes the database
  • changes the API

@Simrayz Simrayz requested a review from hmpf October 20, 2025 12:32
@hmpf hmpf requested a review from a team October 20, 2025 12:52
Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@Simrayz Simrayz mentioned this pull request Oct 22, 2025
10 tasks
@Simrayz Simrayz merged commit 8828801 into chore/upgrade-jquery Oct 24, 2025
19 checks passed
@Simrayz Simrayz deleted the chore/upgrade-jquery-ui branch October 24, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants