-
Notifications
You must be signed in to change notification settings - Fork 46
Upgrade jQuery UI #3613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade jQuery UI #3613
Conversation
Test results 27 files 27 suites 46m 11s ⏱️ Results for commit ff99742. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## chore/upgrade-jquery #3613 +/- ##
========================================================
- Coverage 62.51% 62.49% -0.02%
========================================================
Files 611 611
Lines 45020 45020
Branches 43 43
========================================================
- Hits 28142 28137 -5
- Misses 16868 16873 +5
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1784f24 to
ff7a839
Compare
fcd9641 to
a750aaa
Compare
ff7a839 to
332494d
Compare
a750aaa to
ff99742
Compare
|
hmpf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the easiest way to test that this works?
|
... and this is not correct I hope?
|
hmpf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.



Scope and purpose
This PR upgrades the jQuery UI library, as part of the larger #3582 jQuery update.
How to test
Panels & Tabs
Interface Portlist
Tab Navigation plugin: Location search example
A change was made to the
tab_navigationplugin to use.attr('id')instead of.selector. This plugin is used by multiple views, but it should be enough to test one such usage.#!<tabname>You can also verify that other views with tabs work. However, they do not update the URL has value. Affected views are:
/search/room/100: Verify that tabs workGeneral updates
These views have been modified to use the new jQuery UI version, but no specific changes were made to the files beyond require dependency updates.
$(<selector>).droppable(...)function works.Target *input field works as expected, by searching for a target and waiting for suggestions."View settings" > "Filter by room or location"works./search/room/100Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.