Release DPL4 #348
Release DPL4 #348
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes update the GitHub Actions workflow to run on both Changes
Poem
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| static function ( $oldVal, &$ttl, &$setOpts ) use ( $worker, $dbr ){ | ||
| $setOpts += Database::getCacheSetOptions( $dbr ); | ||
| function ( $oldVal, &$ttl, &$setOpts ) use ( $worker ){ | ||
| $setOpts += Database::getCacheSetOptions( $this->dbr ); |
Check warning
Code scanning / Phpmd (reported by Codacy)
This rule discourages the use of static access in code.
There was a problem hiding this comment.
Phpmd (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/mediawiki-tests.yml (1)
5-8: Minor YAML duplication – consider DRY’ing the branch listThe same two-item list is repeated for both
pushandpull_request. You can keep them in sync with an anchor/alias:on: _branches: &branches [ main, pre-release ] push: branches: *branches pull_request: branches: *branchesPurely cosmetic, but lowers maintenance friction when the branch set changes.
maintenance/CreateView.php (1)
61-66: Safer identifier quoting & optional alias clarificationGood call replacing the custom
$sqlNullMethodlogic with standardCOALESCE. Two quick follow-ups for robustness:
- Quoting / prefixing
Building identifiers manually ({$dbw->tablePrefix()}page) bypasses the DB abstraction’s quoting helpers. UsingtableName()avoids accidental breakage with exotic prefixes:- "CREATE VIEW {$dbw->tablePrefix()}dpl_clview AS SELECT " . + "CREATE VIEW " . $dbw->tableName( 'dpl_clview' ) . " AS SELECT " .…and similarly for
pageandcategorylinks.
- Explicit alias for
cl_sortkey
To keep column names uniform you may wantAS cl_sortkeyafter the third select item.Neither is blocking, but they harden the view for multi-DB setups.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/mediawiki-tests.yml(1 hunks)extension.json(1 hunks)maintenance/CreateView.php(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.php
Instructions used from:
Sources:
⚙️ CodeRabbit Configuration File
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (1)
extension.json (1)
3-3: Use a semantic-version–compatible prerelease string
"PRE.3"does not follow the usualMAJOR.MINOR.PATCH[-prerelease[.N]]pattern (e.g.3.6.5-pre.3). Some packaging tools, ExtensionDistributor and third-party deploy scripts assume numeric prefixes for correct sort order; a non-numeric leading token may break upgrade detection.Please double-check that:
- MediaWiki’s ExtensionRegistry happily parses this value.
- Any deployment scripts comparing versions still work.
If the check fails, consider something like
"3.6.5-pre.3"instead.
Also fixes "column reference "page_title" is ambiguous" as well as the uses parameter when combined with a few other parameters.
Ensure conflict error is still given when using `openreferences = missing`.
Support case insensitive `main` or `(main)` for main namespace as well as support using namespace IDs for all namespaces.
Universal-Omega
changed the title
* **Significantly** improves security around the usage of `LIKE` and many other areas * Adds support for postgresql when using `REGEXP`
We currently just support regex replacements. This adds fallback to string replacement as well if given regex is invalid.
Drops `(main)` as it is the localized version, so decided we shouldn't support unless we support localized blanknamespace message, which we may eventually but not for now.
See
CHANGELOG.mdfor all (at least major) changes.