Skip to content

Commit d554994

Browse files
committed
fix: Fix wrong positioning
- fixes #253 - fixes #2
1 parent 5e710f2 commit d554994

File tree

3 files changed

+5
-12
lines changed

3 files changed

+5
-12
lines changed

src/VueDatePicker/components/composables/position.ts

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,8 @@ export const usePosition = (menuRef: ComponentRef, inputRef: ComponentRef, emit:
2323
});
2424

2525
// Get correct offset of an element
26-
const getOffset = (el: HTMLElement): { top: number; left: number } => {
27-
const rect = el.getBoundingClientRect();
28-
let x = 0;
29-
let y = 0;
30-
while (el && !isNaN(el.offsetLeft) && !isNaN(el.offsetTop)) {
31-
x += el.offsetLeft - el.scrollLeft;
32-
y = rect.top + el.scrollTop;
33-
el = el.offsetParent as HTMLElement;
34-
}
35-
return { top: y, left: x };
26+
const getOffset = (): { top: number; left: number } => {
27+
return { top: 0, left: 0 };
3628
};
3729

3830
const setPositionRight = (left: number, width: number): void => {
@@ -62,7 +54,7 @@ export const usePosition = (menuRef: ComponentRef, inputRef: ComponentRef, emit:
6254

6355
const getInputPositions = (inputEl: HTMLElement) => {
6456
const { width, height } = inputEl.getBoundingClientRect();
65-
const { top, left } = props.altPosition ? props.altPosition(inputEl) : getOffset(inputEl);
57+
const { top, left } = props.altPosition ? props.altPosition(inputEl) : getOffset();
6658
return { top: +top, left: +left, width, height };
6759
};
6860

src/VueDatePicker/style/components/_DatepickerMenu.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
.dp__menu {
2-
position: fixed;
2+
position: absolute;
33
background: var(--dp-background-color);
44
border-radius: $dp__border_radius;
55
min-width: $dp__menu_min_width;

src/VueDatePicker/style/main.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@
6363
font-family: $dp__font_family;
6464
user-select: none;
6565
box-sizing: border-box;
66+
position: relative;
6667
}
6768

6869
.dp__pointer {

0 commit comments

Comments
 (0)