test: update based on 4x change for calculator

Author: rplusq

evm/test/integration/concrete/staking-rewards-calculator/inject-rewards-for-week/injectRewardsForWeek.sol

@@ -9,8 +9,8 @@ contract InjectRewardsForWeek_StakingRewardsCalculator_Integration_Test is
     StakingRewardsCalculator_Integration_Shared_Test
 {
     uint256 constant STAKE_AMOUNT = 5_000_000 ether;
-    uint256 constant REWARDS_AMOUNT = 10_000 ether;
-    uint256 constant EXPECTED_WEEKLY_REWARD = 2816.059 ether;
+    uint256 constant REWARDS_AMOUNT = 50_000 ether;
+    uint256 constant EXPECTED_WEEKLY_REWARD = 11_264.236 ether;
 
     uint256 defaultTimestamp;
 
@@ -210,7 +210,7 @@ contract InjectRewardsForWeek_StakingRewardsCalculator_Integration_Test is
         uint256 rewards = _calculateAndInjectRewards(address(walletConnectConfig), timestamp, false, bytes(""));
 
         // Then: Rewards should be around double (more flexibility for the test)
-        assertApproxEqAbs(rewards, EXPECTED_WEEKLY_REWARD * 2, 1e20, "Rewards should be double for two equal stakers");
+        assertApproxEqAbs(rewards, EXPECTED_WEEKLY_REWARD * 2, 3e20, "Rewards should be double for two equal stakers");
 
         // And: Should transfer tokens from caller to distributor
         assertEq(l2wct.balanceOf(address(stakingRewardDistributor)), rewards, "Distributor should have rewards");

evm/test/invariant/StakingRewardsCalculator.t.sol

@@ -92,11 +92,15 @@ contract StakingRewardsCalculator_Invariant_Test is Invariant_Test {
     }
 
     function invariant_WeeklyRewards_Bounds() public view {
-        // Weekly rewards should never exceed annual rewards divided by WEEKS_IN_YEAR
+        // Weekly rewards should never exceed annual rewards
+        // The calculateWeeklyRewards function uses the formula:
+        // weeklyRewards = (stakeWeight * 4 * apy) / (PRECISION * 100 * WEEKS_IN_YEAR)
         uint256 maxStakeWeight = store.maxRecordedStakeWeight();
         if (maxStakeWeight > 0) {
             uint256 maxWeeklyRewards = calculator.calculateWeeklyRewards(maxStakeWeight, INTERCEPT);
-            uint256 maxAnnualRewards = (maxStakeWeight * uint256(INTERCEPT)) / (PRECISION * 100);
+
+            // Calculate the annual rewards using the same formula but without dividing by WEEKS_IN_YEAR
+            uint256 maxAnnualRewards = (maxStakeWeight * 4 * uint256(INTERCEPT)) / (PRECISION * 100);
 
             assertLe(
                 maxWeeklyRewards * WEEKS_IN_YEAR,
@@ -144,6 +148,8 @@ contract StakingRewardsCalculator_Invariant_Test is Invariant_Test {
             uint256 largerRewards = calculator.calculateWeeklyRewards(largerStake, largerApy);
 
             // Calculate the ratio of stakes and APYs
+            // Note: The multiplication by 4 in calculateWeeklyRewards applies equally to both rewards,
+            // so it doesn't affect the ratio calculation
             uint256 stakeRatio = (largerStake * PRECISION) / smallerStake;
             uint256 apyRatio = (uint256(largerApy) * PRECISION) / uint256(smallerApy);