fix: generating thumbnails may cause the program to hang

Author: hughfenghen

.changeset/wicked-worms-unite.md

@@ -0,0 +1,5 @@
+---
+'@webav/av-cliper': patch
+---
+
+fix: generating thumbnails may cause the program to hang

packages/av-cliper/src/clips/__tests__/mp4-clip.test.ts

@@ -57,6 +57,17 @@ test('thumbnails', async () => {
   clip.destroy();
 });
 
+test('no thumbnails in time range', async () => {
+  const clip = new MP4Clip((await fetch(mp4_bunny)).body!);
+  await clip.ready;
+  const thumbnails = await clip.thumbnails(800, {
+    start: 1e6,
+    end: 2e6,
+  });
+  expect(thumbnails.length).toBe(0);
+  clip.destroy();
+});
+
 test('thumbnails aborted', async () => {
   const clip = new MP4Clip((await fetch(mp4_bunny)).body!);
   await clip.ready;

packages/av-cliper/src/clips/mp4-clip.ts

@@ -1380,7 +1380,10 @@ async function thumbnailByKeyFrame(
     ),
     fileReader,
   );
-  if (chunks.length === 0 || abortSingl.aborted) return;
+  if (chunks.length === 0 || abortSingl.aborted) {
+    onOutput(null, true);
+    return;
+  }
 
   let outputCnt = 0;
   decodeGoP(createVideoDec(), chunks, {