Commit 73f49fd
committed
[Modern Media Controls] remove window event listeners at deinitialization
https://bugs.webkit.org/show_bug.cgi?id=280503
Reviewed by Ryan Reno.
DOMWindow keeps media controls object alive because of installed event listeners (see
JSDOMWindow::visitAdditionalChildren). This results in extra memory usage undil DOMWindow cleared (on top level
navigation).
Original patch by Eugene Mutavchi <[email protected]>.
* Source/WebCore/Modules/modern-media-controls/controls/media-controls.js:
(MediaControls.prototype.reenable):
* Source/WebCore/Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype.deinitialize):
(MediaController.prototype.reinitialize):
Canonical link: https://commits.webkit.org/284440@main1 parent c7d98eb commit 73f49fd
File tree
2 files changed
+12
-0
lines changed- Source/WebCore/Modules/modern-media-controls
- controls
- media
2 files changed
+12
-0
lines changedLines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
254 | 254 | | |
255 | 255 | | |
256 | 256 | | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
257 | 263 | | |
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
222 | 222 | | |
223 | 223 | | |
224 | 224 | | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
225 | 228 | | |
226 | 229 | | |
227 | 230 | | |
| |||
232 | 235 | | |
233 | 236 | | |
234 | 237 | | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
235 | 241 | | |
236 | 242 | | |
237 | 243 | | |
| |||
0 commit comments