[EME][GStreamer][Thunder] Complete removeSessionData implementation

https://bugs.webkit.org/show_bug.cgi?id=303463

Reviewed by Philippe Normand.

We were missing to clear up the session and update and clear the keys.

Original patch by Santhosh-Kumar-infosys <[email protected]>.

* Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp:
(WebCore::CDMInstanceSessionThunder::sessionChanged):
(WebCore::CDMInstanceSessionThunder::updateLicense):
(WebCore::CDMInstanceSessionThunder::loadSession):
(WebCore::CDMInstanceSessionThunder::removeSessionData):
(WebCore::CDMInstanceSessionThunder::sessionFailure): Deleted.
* Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.h:

Canonical link: https://commits.webkit.org/303826@main

This fixes #1585.

Author: calvaris

Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp

@@ -546,10 +546,10 @@ void CDMInstanceSessionThunder::requestLicense(LicenseType licenseType, const At
         m_challengeCallbacks.append(WTFMove(generateChallenge));
 }
 
-void CDMInstanceSessionThunder::sessionFailure()
+void CDMInstanceSessionThunder::sessionChanged(SessionChangedResult result)
 {
     for (auto& sessionChangedCallback : m_sessionChangedCallbacks)
-        sessionChangedCallback(false, nullptr);
+        sessionChangedCallback(result == SessionChangedResult::Success, nullptr);
     m_sessionChangedCallbacks.clear();
 }
 
@@ -591,7 +591,7 @@ void CDMInstanceSessionThunder::updateLicense(const String& sessionID, LicenseTy
     });
     auto responseData = response->extractData();
     if (!m_session || m_sessionID.isEmpty() || opencdm_session_update(m_session->get(), responseData.data(), responseData.size()))
-        sessionFailure();
+        sessionChanged(SessionChangedResult::Failure);
 }
 
 void CDMInstanceSessionThunder::loadSession(LicenseType, const String& sessionID, const String&, LoadSessionCallback&& callback)
@@ -636,7 +636,7 @@ void CDMInstanceSessionThunder::loadSession(LicenseType, const String& sessionID
     });
     if (!m_session || m_sessionID.isEmpty() || opencdm_session_load(m_session->get())) {
         GST_DEBUG("loading failed");
-        sessionFailure();
+        sessionChanged(SessionChangedResult::Failure);
     }
 }
 
@@ -684,7 +684,14 @@ void CDMInstanceSessionThunder::removeSessionData(const String& sessionID, Licen
         }
     });
     if (!m_session || m_sessionID.isEmpty() || opencdm_session_remove(m_session->get()))
-        sessionFailure();
+        sessionChanged(SessionChangedResult::Failure);
+    else
+        sessionChanged(SessionChangedResult::Success);
+    m_session = BoxPtr<OpenCDMSession>();
+    auto instance = cdmInstanceThunder();
+    if (instance)
+        instance->unrefAllKeysFrom(m_keyStore);
+    m_keyStore.clear();
 }
 
 void CDMInstanceSessionThunder::storeRecordOfKeyUsage(const String&)

Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.h

@@ -150,7 +150,12 @@ class CDMInstanceSessionThunder final : public CDMInstanceSessionProxy {
     void keysUpdateDoneCallback();
     void errorCallback(RefPtr<SharedBuffer>&&);
     CDMInstanceSession::KeyStatus status(const KeyIDType&) const;
-    void sessionFailure();
+
+    enum class SessionChangedResult : bool {
+        Failure,
+        Success
+    };
+    void sessionChanged(SessionChangedResult);
 
     // FIXME: Check all original uses of these attributes.
     String m_sessionID;