Skip to content

Commit 614aae6

Browse files
committed
Adjust types to hint possible WP_Error usage in callbacks
1 parent 610a302 commit 614aae6

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

includes/abilities-api.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
* input_schema?: array<string,mixed>,
3737
* output_schema?: array<string,mixed>,
3838
* execute_callback?: callable( array<string,mixed> $input): (mixed|\WP_Error),
39-
* permission_callback?: callable( ?array<string,mixed> $input ): bool,
39+
* permission_callback?: callable( array<string,mixed> $input ): (bool|\WP_Error),
4040
* meta?: array<string,mixed>,
4141
* ability_class?: class-string<\WP_Ability>,
4242
* ...<string, mixed>

includes/abilities-api/class-wp-abilities-registry.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ final class WP_Abilities_Registry {
5757
* input_schema?: array<string,mixed>,
5858
* output_schema?: array<string,mixed>,
5959
* execute_callback?: callable( array<string,mixed> $input): (mixed|\WP_Error),
60-
* permission_callback?: ?callable( ?array<string,mixed> $input ): bool,
60+
* permission_callback?: ?callable( array<string,mixed> $input ): (bool|\WP_Error),
6161
* meta?: array<string,mixed>,
6262
* ability_class?: class-string<\WP_Ability>,
6363
* ...<string, mixed>

includes/abilities-api/class-wp-ability.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,15 +65,15 @@ class WP_Ability {
6565
* The ability execute callback.
6666
*
6767
* @since 0.1.0
68-
* @var callable
68+
* @var callable( array<string,mixed> $input): (mixed|\WP_Error)
6969
*/
7070
protected $execute_callback;
7171

7272
/**
7373
* The optional ability permission callback.
7474
*
7575
* @since 0.1.0
76-
* @var ?callable
76+
* @var ?callable( array<string,mixed> $input ): (bool|\WP_Error)
7777
*/
7878
protected $permission_callback = null;
7979

@@ -107,7 +107,7 @@ class WP_Ability {
107107
* input_schema?: array<string,mixed>,
108108
* output_schema?: array<string,mixed>,
109109
* execute_callback: callable( array<string,mixed> $input): (mixed|\WP_Error),
110-
* permission_callback?: ?callable( ?array<string,mixed> $input ): bool,
110+
* permission_callback?: ?callable( array<string,mixed> $input ): (bool|\WP_Error),
111111
* meta?: array<string,mixed>,
112112
* ...<string, mixed>,
113113
* } $properties
@@ -280,7 +280,7 @@ public function has_permission( array $input = array() ) {
280280
*
281281
* @since 0.1.0
282282
*
283-
* @param bool $permission_result The current permission result.
283+
* @param bool|\WP_Error $permission_result The current permission result.
284284
* @param string $ability_name The ability name.
285285
* @param array<string,mixed> $input The input for the ability.
286286
* @return bool|\WP_Error The filtered permission result.

0 commit comments

Comments
 (0)