- 
                Notifications
    
You must be signed in to change notification settings  - Fork 13
 
[Blueprints v2] Playground CLI compatibility #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    …move support for the 'importWordPressFiles' in its v1 shape, use the correct DOCROOT in the NewSiteResolver
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Implements a series of bugfixes and improvements to enable integration with WordPress Playground. Some highlights:
blueprint.http_clientfilter so Playground can setup its own HTTP Client instanceblueprint.resolvedfilter to enable injecting additional steps in PlaygroundRequestReadStreamdoesn't expectContent-LengthwhenContent-Encodingis present.WPCLIStepnow gets an explicit--pathargument to avoid relying on WordPress autodetection heuristicslatestis now a valid WordPress version identifiernew_site_content_root_urland a few other options when they can't be backfilled via WordPress functions. For example, when WordPress hasn't yet been loadedcreate-new-site, are replaced with constants, such asself::EXECUTION_MODE_CREATE_NEW_SITETesting instructions
Confirm the CLI failures are in line with
trunk(most successes, some flaky failures)