phpstan fixes (#120)

Author: pkevan

bin/baseline.neon

@@ -90,18 +90,6 @@ parameters:
 			count: 1
 			path: ../includes/admin/views/upgrade/notice.php
 
-		-
-			message: '#^Function remove_filter invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 1
-			path: ../includes/api/api-helpers.php
-
-		-
-			message: '#^One or more @param tags has an invalid name or invalid syntax\.$#'
-			identifier: phpDoc.parseError
-			count: 1
-			path: ../includes/api/api-helpers.php
-
 		-
 			message: '#^Path in include_once\(\) "\./wp\-admin/includes/plugin\.php" is not a file or it does not exist\.$#'
 			identifier: includeOnce.fileNotFound
@@ -126,12 +114,6 @@ parameters:
 			count: 1
 			path: ../includes/api/api-helpers.php
 
-		-
-			message: '#^Function remove_filter invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 1
-			path: ../includes/api/api-term.php
-
 		-
 			message: '#^Action callback returns string but should not return anything\.$#'
 			identifier: return.void

includes/api/api-helpers.php

@@ -1289,7 +1289,7 @@ function acf_get_grouped_posts( $args ) {
 
 	// remove this filter (only once)
 	if ( ! $is_single_post_type ) {
-		remove_filter( 'posts_orderby', '_acf_orderby_post_type', 10, 2 );
+		remove_filter( 'posts_orderby', '_acf_orderby_post_type', 10 );
 	}
 
 	// loop
@@ -2605,7 +2605,7 @@ function acf_get_attachment( $attachment ) {
 		 *
 		 * @since ACF 6.2.2
 		 *
-		 * @param int|null The default filesize.
+		 * @param int|null $shortcut_filesize The default filesize.
 		 * @param WP_Post $attachment The attachment post object we're looking for the filesize for.
 		 */
 		$shortcut_filesize = apply_filters( 'acf/filesize', null, $attachment );

includes/api/api-term.php

@@ -192,7 +192,7 @@ function acf_get_grouped_terms( $args ) {
 
 	// remove this filter (only once)
 	if ( ! $is_single ) {
-		remove_filter( 'terms_clauses', '_acf_terms_clauses', 10, 3 );
+		remove_filter( 'terms_clauses', '_acf_terms_clauses', 10 );
 	}
 
 	// loop