wip

Author: JanJakes

tests/WP_SQLite_Driver_Tests.php

@@ -5861,7 +5861,7 @@ public function testDropIndex(): void {
 	}
 
 	public function testColumnInfo(): void {
-		$this->assertQuery( 'CREATE TABLE t (id INT, name TEXT, score FLOAT, data BLOB)' );
+		$this->assertQuery( 'CREATE TABLE t (id INT, name TEXT, score DOUBLE, data BLOB)' );
 		$this->assertQuery( 'SELECT * FROM t' );
 
 		$this->assertEquals( 4, $this->engine->get_last_column_count() );
@@ -5876,8 +5876,7 @@ public function testColumnInfo(): void {
 				'flags'            => array(),
 				'table'            => 't',
 				'name'             => 'id',
-				//'len' => 11,
-				'len'              => -1,
+				'len'              => 11,
 				'precision'        => 0,
 				'sqlite:decl_type' => 'INTEGER',
 			),
@@ -5891,8 +5890,7 @@ public function testColumnInfo(): void {
 				'flags'            => array( 'blob' ),
 				'table'            => 't',
 				'name'             => 'name',
-				//'len' => 262140,
-				'len'              => -1,
+				'len'              => 262140,
 				'precision'        => 0,
 				'sqlite:decl_type' => 'TEXT',
 			),
@@ -5906,10 +5904,8 @@ public function testColumnInfo(): void {
 				'flags'            => array(),
 				'table'            => 't',
 				'name'             => 'score',
-				//'len' => 22,
-				'len'              => -1,
-				//'precision' => 31,
-				'precision'        => 0,
+				'len'              => 22,
+				'precision'        => 31,
 				'sqlite:decl_type' => 'REAL',
 			),
 			$column_info[2]
@@ -5922,8 +5918,7 @@ public function testColumnInfo(): void {
 				'flags'            => array( 'blob' ),
 				'table'            => 't',
 				'name'             => 'data',
-				//'len' => 65535,
-				'len'              => -1,
+				'len'              => 65535,
 				'precision'        => 0,
 				'sqlite:decl_type' => 'BLOB',
 			),

wp-includes/sqlite-ast/class-wp-sqlite-driver.php

@@ -768,12 +768,77 @@ public function get_last_column_meta(): array {
 		// Build the column metadata as per "PDOStatement::getColumnMeta()".
 		$column_meta = array();
 		for ( $i = 0; $i < $this->last_column_meta_statement->columnCount(); $i++ ) {
-			$meta = $this->last_column_meta_statement->getColumnMeta( $i );
+			$meta  = $this->last_column_meta_statement->getColumnMeta( $i );
+			$table = $meta['table'];
+			$name  = $meta['name'];
 
+			// Types.
 			$sqlite_type = $meta['sqlite:decl_type'];
 			$native_type = $native_types[ $sqlite_type ] ?? null;
 			$pdo_type    = $pdo_types[ $sqlite_type ] ?? PDO::PARAM_NULL;
 
+			// Length and precision.
+			$len       = $meta['len'];
+			$precision = $meta['precision'];
+
+			// When table is known, we can get data from the information schema.
+			if ( strlen( $table ) > 0 ) {
+				$table_is_temporary = $this->information_schema_builder->temporary_table_exists( $table );
+				$columns_table      = $this->information_schema_builder->get_table_name( $table_is_temporary, 'columns' );
+				$column_info        = $this->execute_sqlite_query(
+					sprintf(
+						'
+							SELECT
+								DATA_TYPE,
+								COLUMN_TYPE,
+								CHARACTER_MAXIMUM_LENGTH,
+								NUMERIC_PRECISION
+							FROM %s
+							WHERE TABLE_SCHEMA = ? AND TABLE_NAME = ? AND COLUMN_NAME = ?
+						',
+						$this->quote_sqlite_identifier( $columns_table )
+					),
+					array( $this->db_name, $table, $name )
+				)->fetch( PDO::FETCH_ASSOC );
+
+				// If set, lenght can be taken from the information schema.
+				if ( isset( $column_info['CHARACTER_MAXIMUM_LENGTH'] ) ) {
+					$len = (int) $column_info['CHARACTER_MAXIMUM_LENGTH'];
+				}
+
+				// For string types, the length is multiplied by the maximum number
+				// of bytes per character for the used connection encoding. In our
+				// case, it's always "utf8mb4" and therefore 4 bytes per character.
+				if (
+					str_contains( $column_info['DATA_TYPE'], 'text' )
+					|| str_contains( $column_info['DATA_TYPE'], 'char' )
+				) {
+					$len = 4 * $len;
+				}
+
+				// For integer and real types, the length is the number of digits.
+				if ( 'INTEGER' === $sqlite_type || 'REAL' === $sqlite_type ) {
+					$len = (int) $column_info['NUMERIC_PRECISION'];
+				}
+
+				// Signed "int" and "bigint" numbers are 1 byte longer than unsigned.
+				if (
+					( 'int' === $column_info['DATA_TYPE'] || 'bigint' === $column_info['DATA_TYPE'] )
+					&& ! str_contains( $column_info['COLUMN_TYPE'], 'unsigned' )
+				) {
+					$len += 1;
+				}
+			}
+
+			// Precision.
+			if ( 'REAL' === $sqlite_type ) {
+				//$precision = (int) ( $column_info['precision'] ?? $meta['precision'] );
+				//$precision = 31;
+			} else {
+				//$precision = 0;
+			}
+
+			// Flags.
 			$flags = array();
 			if ( 'BLOB' === $native_type ) {
 				$flags[] = 'blob';
@@ -785,8 +850,8 @@ public function get_last_column_meta(): array {
 				'flags'            => $flags,
 				'table'            => $meta['table'],
 				'name'             => $meta['name'],
-				'len'              => $meta['len'],
-				'precision'        => $meta['precision'],
+				'len'              => $len,
+				'precision'        => $precision,
 				'sqlite:decl_type' => $meta['sqlite:decl_type'],
 			);
 		}