-
Notifications
You must be signed in to change notification settings - Fork 75
fix: Match ledger_entry error codes with rippled #2549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Match ledger_entry error codes with rippled #2549
Conversation
336e2d3 to
a0d827c
Compare
godexsoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this 👍 I just have one question. Otherwise it looks good and I believe it matches the rippled PR 👍
|
As @emreariyurek suggested (and is evident from failing CI) this requires a newer libXRPL than what we currently have. Putting this on hold till then. |
|
@godexsoft @emreariyurek Ah, so I just checked. The PR to update ledger entry error codes is not included in libxrpl 2.6.1, we can move this to next release of clio 👍 |
PeterChen13579
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this task @emreariyurek ! Just one quick comment on my side
Yeah, that was expected since this was not in the beta nor in the rc we tried with.. next release it is 👍 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2549 +/- ##
===========================================
- Coverage 82.01% 81.99% -0.02%
===========================================
Files 378 378
Lines 14208 14210 +2
Branches 7843 7844 +1
===========================================
Hits 11652 11652
- Misses 1438 1439 +1
- Partials 1118 1119 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PeterChen13579
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fix #2540
Precondition: Ensure that the changes from 2540 are applied to xrpl.