Skip to content

Conversation

@emreariyurek
Copy link
Contributor

@emreariyurek emreariyurek commented Sep 8, 2025

Fix #2540

Precondition: Ensure that the changes from 2540 are applied to xrpl.

@emreariyurek emreariyurek force-pushed the emre_2540_match_ledger_entry_error_codes branch from 336e2d3 to a0d827c Compare September 8, 2025 17:48
Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this 👍 I just have one question. Otherwise it looks good and I believe it matches the rippled PR 👍

@godexsoft godexsoft added the on hold For issues that currently wait on other issues label Sep 17, 2025
@godexsoft
Copy link
Collaborator

As @emreariyurek suggested (and is evident from failing CI) this requires a newer libXRPL than what we currently have. Putting this on hold till then.

@PeterChen13579
Copy link
Collaborator

@godexsoft @emreariyurek Ah, so I just checked. The PR to update ledger entry error codes is not included in libxrpl 2.6.1, we can move this to next release of clio 👍

Copy link
Collaborator

@PeterChen13579 PeterChen13579 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this task @emreariyurek ! Just one quick comment on my side

@godexsoft
Copy link
Collaborator

@godexsoft @emreariyurek Ah, so I just checked. The PR to update ledger entry error codes is not included in libxrpl 2.6.1, we can move this to next release of clio 👍

Yeah, that was expected since this was not in the beta nor in the rc we tried with.. next release it is 👍

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.99%. Comparing base (3a4249d) to head (23e2ae9).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/rpc/handlers/LedgerEntry.cpp 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2549      +/-   ##
===========================================
- Coverage    82.01%   81.99%   -0.02%     
===========================================
  Files          378      378              
  Lines        14208    14210       +2     
  Branches      7843     7844       +1     
===========================================
  Hits         11652    11652              
- Misses        1438     1439       +1     
- Partials      1118     1119       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathbunnyru mathbunnyru removed the on hold For issues that currently wait on other issues label Nov 13, 2025
@mathbunnyru mathbunnyru marked this pull request as ready for review November 13, 2025 17:01
Copy link
Collaborator

@PeterChen13579 PeterChen13579 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mathbunnyru mathbunnyru merged commit 2075171 into XRPLF:develop Nov 17, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Match ledger_entry error codes with rippled

4 participants