Skip to content

Commit 1c38bbd

Browse files
committed
Review feedback from @gregtatcam
- Remove unneeded proxy variables. Set the fields directly.
1 parent 590f69c commit 1c38bbd

File tree

1 file changed

+5
-11
lines changed

1 file changed

+5
-11
lines changed

src/xrpld/app/tx/detail/LoanManage.cpp

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -135,13 +135,6 @@ LoanManage::defaultLoan(
135135
std::int32_t const loanScale = loanSle->at(sfLoanScale);
136136
auto brokerDebtTotalProxy = brokerSle->at(sfDebtTotal);
137137

138-
auto principalOutstandingProxy = loanSle->at(sfPrincipalOutstanding);
139-
auto managementFeeOutstandingProxy =
140-
loanSle->at(sfManagementFeeOutstanding);
141-
142-
auto totalValueOutstandingProxy = loanSle->at(sfTotalValueOutstanding);
143-
auto paymentRemainingProxy = loanSle->at(sfPaymentRemaining);
144-
145138
Number const totalDefaultAmount = owedToVault(loanSle);
146139

147140
// Apply the First-Loss Capital to the Default Amount
@@ -267,10 +260,11 @@ LoanManage::defaultLoan(
267260

268261
// Update the Loan object:
269262
loanSle->setFlag(lsfLoanDefault);
270-
totalValueOutstandingProxy = 0;
271-
paymentRemainingProxy = 0;
272-
principalOutstandingProxy = 0;
273-
managementFeeOutstandingProxy = 0;
263+
264+
loanSle->at(sfTotalValueOutstanding) = 0;
265+
loanSle->at(sfPaymentRemaining) = 0;
266+
loanSle->at(sfPrincipalOutstanding) = 0;
267+
loanSle->at(sfManagementFeeOutstanding) = 0;
274268
// Zero out the next due date. Since it's default, it'll be removed from
275269
// the object.
276270
loanSle->at(sfNextPaymentDueDate) = 0;

0 commit comments

Comments
 (0)