Skip to content

Commit 5223459

Browse files
committed
Fix a couple of build errors
1 parent 5997df7 commit 5223459

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/xrpld/app/tx/detail/LoanBroker.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
#include <xrpl/protocol/PublicKey.h>
3636
#include <xrpl/protocol/SField.h>
3737
#include <xrpl/protocol/STAmount.h>
38+
#include <xrpl/protocol/STNumber.h>
3839
#include <xrpl/protocol/STObject.h>
3940
#include <xrpl/protocol/STXChainBridge.h>
4041
#include <xrpl/protocol/TER.h>
@@ -68,11 +69,11 @@ LoanBrokerSet::doPreflight(PreflightContext const& ctx)
6869
auto const& tx = ctx.tx;
6970
if (!validDataLength(tx[~sfData], maxDataPayloadLength))
7071
return temINVALID;
71-
if (!validNumericRange(tx[~sfManagementFeeRate], 0, maxFeeRate))
72+
if (!validNumericRange(tx[~sfManagementFeeRate], maxFeeRate))
7273
return temINVALID;
73-
if (!validNumericRange(tx[~sfCoverRateMinimum], 0, maxCoverRate))
74+
if (!validNumericRange(tx[~sfCoverRateMinimum], maxCoverRate))
7475
return temINVALID;
75-
if (!validNumericRange(tx[~sfCoverRateLiquidation], 0, maxCoverRate))
76+
if (!validNumericRange(tx[~sfCoverRateLiquidation], maxCoverRate))
7677
return temINVALID;
7778

7879
if (tx.isFieldPresent(sfLoanBrokerID))
@@ -187,7 +188,7 @@ LoanBrokerSet::doApply()
187188
broker->at(sfData) = *data;
188189
if (auto const rate = tx[~sfManagementFeeRate])
189190
broker->at(sfManagementFeeRate) = *rate;
190-
if (auto const debtMax = tx[~sfDebtMaximum]; debtMax && *debtMax)
191+
if (auto const debtMax = tx[~sfDebtMaximum]; debtMax)
191192
broker->at(sfDebtMaximum) = *debtMax;
192193
if (auto const coverMin = tx[~sfCoverRateMinimum])
193194
broker->at(sfCoverRateMinimum) = *coverMin;

src/xrpld/app/tx/detail/Transactor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ class Transactor
217217

218218
template <class T>
219219
static bool
220-
validNumericRange(std::optional<T> value, T min, T max);
220+
validNumericRange(std::optional<T> value, T max, T min = {});
221221

222222
private:
223223
std::pair<TER, XRPAmount>

0 commit comments

Comments
 (0)