ci: fix flakiness of snippet tests (hopefully) (#823)

Author: mvadari

.github/workflows/snippet_test.yml

@@ -48,4 +48,4 @@ jobs:
         run: poetry install
 
       - name: Run Snippets
-        run: (for i in snippets/*.py; do echo "Running $i" && poetry run python $i || exit 1; done)
+        run: (for i in snippets/*.py; do echo "Running $i" && poetry run python $i && sleep 5 || exit 1; done)

snippets/send_escrow.py

@@ -7,7 +7,7 @@
 from xrpl.clients import JsonRpcClient
 from xrpl.models import AccountObjects, EscrowCreate, EscrowFinish
 from xrpl.transaction.reliable_submission import submit_and_wait
-from xrpl.utils import datetime_to_ripple_time
+from xrpl.utils import datetime_to_ripple_time, xrp_to_drops
 from xrpl.wallet import generate_faucet_wallet
 
 # References
@@ -19,33 +19,33 @@
 client = JsonRpcClient("https://s.altnet.rippletest.net:51234")
 
 # Creating two wallets to send money between
-wallet1 = generate_faucet_wallet(client, debug=True)
-wallet2 = generate_faucet_wallet(client, debug=True)
+wallet = generate_faucet_wallet(client, debug=True)
+destination = "rPT1Sjq2YGrBMTttX4GZHjKu9dyfzbpAYe"
 
 # Both balances should be zero since nothing has been sent yet
 print("Balances of wallets before Escrow tx was created:")
-print(get_balance(wallet1.address, client))
-print(get_balance(wallet2.address, client))
+print(get_balance(wallet.address, client))
+print(get_balance(destination, client))
 
 # Create a finish time (8 seconds from last ledger close)
 finish_after = datetime_to_ripple_time(datetime.now()) + 8
 
 # Create an EscrowCreate transaction, then sign, autofill, and send it
 create_tx = EscrowCreate(
-    account=wallet1.address,
-    destination=wallet2.address,
-    amount="1000000",
+    account=wallet.address,
+    destination=destination,
+    amount=xrp_to_drops(50),
     finish_after=finish_after,
 )
 
-create_escrow_response = submit_and_wait(create_tx, client, wallet1)
+create_escrow_response = submit_and_wait(create_tx, client, wallet)
 print(create_escrow_response)
 
 # Create an AccountObjects request and have the client call it to see if escrow exists
-account_objects_request = AccountObjects(account=wallet1.address)
+account_objects_request = AccountObjects(account=wallet.address)
 account_objects = (client.request(account_objects_request)).result["account_objects"]
 
-print("Escrow object exists in wallet1's account:")
+print("Escrow object exists in wallet's account:")
 print(account_objects)
 
 print("Waiting for the escrow finish time to pass...")
@@ -54,14 +54,14 @@
 
 # Create an EscrowFinish transaction, then sign, autofill, and send it
 finish_tx = EscrowFinish(
-    account=wallet1.address,
-    owner=wallet1.address,
+    account=wallet.address,
+    owner=wallet.address,
     offer_sequence=create_escrow_response.result["tx_json"]["Sequence"],
 )
 
-submit_and_wait(finish_tx, client, wallet1)
+submit_and_wait(finish_tx, client, wallet)
 
-# If escrow went through successfully, 1000000 exchanged
+# If escrow went through successfully, 50 XRP exchanged
 print("Balances of wallets after Escrow was sent:")
-print(get_balance(wallet1.address, client))
-print(get_balance(wallet2.address, client))
+print(get_balance(wallet.address, client))
+print(get_balance(destination, client))

snippets/set_regular_key.py

@@ -4,7 +4,8 @@
 from xrpl.clients import JsonRpcClient
 from xrpl.models import Payment, SetRegularKey
 from xrpl.transaction import submit_and_wait
-from xrpl.wallet import generate_faucet_wallet
+from xrpl.utils import xrp_to_drops
+from xrpl.wallet import Wallet, generate_faucet_wallet
 
 # References
 # - https://xrpl.org/assign-a-regular-key-pair.html#assign-a-regular-key-pair
@@ -15,37 +16,37 @@
 client = JsonRpcClient("https://s.altnet.rippletest.net:51234")
 
 # Creating two wallets to send money between
-wallet1 = generate_faucet_wallet(client, debug=True)
-wallet2 = generate_faucet_wallet(client, debug=True)
-regular_key_wallet = generate_faucet_wallet(client, debug=True)
+wallet = generate_faucet_wallet(client, debug=True)
+destination = "rPT1Sjq2YGrBMTttX4GZHjKu9dyfzbpAYe"
+regular_key_wallet = Wallet.create()
 
 # Both balances should be zero since nothing has been sent yet
 print("Balances before payment:")
-print(get_balance(wallet1.address, client))
-print(get_balance(wallet2.address, client))
+print(get_balance(wallet.address, client))
+print(get_balance(destination, client))
 
-# Assign key pair (regular_key_wallet) to wallet1 using SetRegularKey transaction
-tx = SetRegularKey(account=wallet1.address, regular_key=regular_key_wallet.address)
+# Assign key pair (regular_key_wallet) to wallet using SetRegularKey transaction
+tx = SetRegularKey(account=wallet.address, regular_key=regular_key_wallet.address)
 
-set_regular_key_response = submit_and_wait(tx, client, wallet1)
+set_regular_key_response = submit_and_wait(tx, client, wallet)
 
 print("Response for successful SetRegularKey tx:")
 print(set_regular_key_response)
 
-# Since regular_key_wallet is linked to wallet1,
-# walet1 can send payment to wallet2 and have regular_key_wallet sign it
+# Since regular_key_wallet is linked to wallet,
+# wallet can send payment to destination and have regular_key_wallet sign it
 payment = Payment(
-    account=wallet1.address,
-    destination=wallet2.address,
-    amount="1000",
+    account=wallet.address,
+    destination=destination,
+    amount=xrp_to_drops(50),
 )
 
 payment_response = submit_and_wait(payment, client, regular_key_wallet)
 
 print("Response for tx signed using Regular Key:")
 print(payment_response)
 
-# Balance after sending 1000 from wallet1 to wallet2
+# Balance after sending 50 XRP from wallet1 to wallet2
 print("Balances after payment:")
-print(get_balance(wallet1.address, client))
-print(get_balance(wallet2.address, client))
+print(get_balance(wallet.address, client))
+print(get_balance(destination, client))

snippets/submit_payment.py

@@ -4,6 +4,7 @@
 from xrpl.clients import JsonRpcClient
 from xrpl.models import Payment, Tx
 from xrpl.transaction import submit_and_wait
+from xrpl.utils import xrp_to_drops
 from xrpl.wallet import generate_faucet_wallet
 
 # References:
@@ -15,24 +16,24 @@
 client = JsonRpcClient("https://s.altnet.rippletest.net:51234")
 
 # Creating two wallets to send money between
-wallet1 = generate_faucet_wallet(client, debug=True)
-wallet2 = generate_faucet_wallet(client, debug=True)
+wallet = generate_faucet_wallet(client, debug=True)
+destination = "rPT1Sjq2YGrBMTttX4GZHjKu9dyfzbpAYe"
 
 # Both balances should be zero since nothing has been sent yet
 print("Balances of wallets before Payment tx")
-print(get_balance(wallet1.address, client))
-print(get_balance(wallet2.address, client))
+print(get_balance(wallet.address, client))
+print(get_balance(destination, client))
 
 # Create a Payment transaction
 payment_tx = Payment(
-    account=wallet1.address,
-    amount="1000",
-    destination=wallet2.address,
+    account=wallet.address,
+    amount=xrp_to_drops(50),
+    destination=destination,
 )
 
 # Signs, autofills, and submits transaction and waits for response
 # (validated or rejected)
-payment_response = submit_and_wait(payment_tx, client, wallet1)
+payment_response = submit_and_wait(payment_tx, client, wallet)
 print("Transaction was submitted")
 
 # Create a Transaction request to see transaction
@@ -41,7 +42,7 @@
 # Check validated field on the transaction
 print("Validated:", tx_response.result["validated"])
 
-# Check balances after 1000 was sent from wallet1 to wallet2
+# Check balances after 50 XRP was sent from wallet to destination
 print("Balances of wallets after Payment tx:")
-print(get_balance(wallet1.address, client))
-print(get_balance(wallet2.address, client))
+print(get_balance(wallet.address, client))
+print(get_balance(destination, client))