Skip to content

Commit 8197ec8

Browse files
authored
fix: NPE with test JSONRPCHandlerTest.testOnMessageNewMessageSuccessMocks (#444)
Simple fix for JSONRPCHandlerTest.testOnMessageNewMessageSuccessMocks ensuring that the DoneCallback is not null when mocking. Signed-off-by: Emmanuel Hugonnet <[email protected]>
1 parent 465a5e4 commit 8197ec8

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

server-common/src/main/java/io/a2a/server/events/EnhancedRunnable.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package io.a2a.server.events;
22

3-
import java.util.ArrayList;
43
import java.util.List;
54
import java.util.concurrent.CopyOnWriteArrayList;
65

transport/jsonrpc/src/test/java/io/a2a/transport/jsonrpc/handler/JSONRPCHandlerTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,8 @@ public void testOnMessageNewMessageSuccessMocks() {
186186
SendMessageResponse response;
187187
try (MockedConstruction<EventConsumer> mocked = Mockito.mockConstruction(
188188
EventConsumer.class,
189-
(mock, context) -> {Mockito.doReturn(ZeroPublisher.fromItems(wrapEvent(MINIMAL_TASK))).when(mock).consumeAll();})){
189+
(mock, context) -> {Mockito.doReturn(ZeroPublisher.fromItems(wrapEvent(MINIMAL_TASK))).when(mock).consumeAll();
190+
Mockito.doCallRealMethod().when(mock).createAgentRunnableDoneCallback();})){
190191
response = handler.onMessageSend(request, callContext);
191192
}
192193
assertNull(response.getError());

0 commit comments

Comments
 (0)