File tree Expand file tree Collapse file tree 2 files changed +20
-7
lines changed Expand file tree Collapse file tree 2 files changed +20
-7
lines changed Original file line number Diff line number Diff line change @@ -86,9 +86,13 @@ CLASS zcl_settings IMPLEMENTATION.
8686
8787 METHOD check_settings .
8888
89- IF zcl_package_json_valid=>is_valid_url( is_settings-registry ) = abap_false .
90- INSERT | Invalid registry URL: { is_settings-registry } | INTO TABLE result .
91- ENDIF .
89+ TRY .
90+ IF is_settings-registry IS NOT INITIAL .
91+ zcl_url=>parse( is_settings-registry ).
92+ ENDIF .
93+ CATCH zcx_error.
94+ INSERT | Invalid registry URL: { is_settings-registry } | INTO TABLE result .
95+ ENDTRY .
9296
9397 ENDMETHOD .
9498
@@ -140,14 +144,21 @@ CLASS zcl_settings IMPLEMENTATION.
140144 METHOD get_default .
141145
142146 " Default values for settings
143- result-registry = zif_settings=>c_registry.
147+ " TODO: Change to production registry
148+ result-registry = zif_settings=>c_playground.
149+
150+ result-list_settings-order_by = 'PACKAGE' .
144151
145152 ENDMETHOD .
146153
147154
148155 METHOD get_setting_key .
149156
150- result = | { zif_persist_apm=>c_key_type-settings } :{ name } | .
157+ IF name = zif_settings=>c_global.
158+ result = | { zif_persist_apm=>c_key_type-settings } :{ zif_settings=>c_global } :ALL| .
159+ ELSE .
160+ result = | { zif_persist_apm=>c_key_type-settings } :{ zif_settings=>c_user } :{ name } | .
161+ ENDIF .
151162
152163 ENDMETHOD .
153164
Original file line number Diff line number Diff line change @@ -50,8 +50,10 @@ INTERFACE zif_settings PUBLIC.
5050 TYPES ty_name TYPE uname.
5151
5252 CONSTANTS :
53- c_registry TYPE string VALUE 'https://registry.abappm.com' ,
54- c_global TYPE ty_name VALUE zif_persist_apm=>c_key_name-global_settings.
53+ c_registry TYPE string VALUE 'https://registry.abappm.com' ,
54+ c_playground TYPE string VALUE 'https://playground.abappm.com' ,
55+ c_global TYPE ty_name VALUE zif_persist_apm=>c_key_name-global_settings,
56+ c_user TYPE ty_name VALUE zif_persist_apm=>c_key_name-user_settings.
5557
5658 METHODS get
5759 RETURNING
You can’t perform that action at this time.
0 commit comments