Use absolute path to spawn test commands

Signed-off-by: Philippe Ombredanne <[email protected]>

Author: pombredanne

tests/data/tilde_req-expected-env.json

@@ -0,0 +1,78 @@
+{
+  "headers": {
+    "tool_name": "python-inspector",
+    "tool_homepageurl": "https://github.com/aboutcode-org/python-inspector",
+    "options": [
+      "--index-url https://pypi.org/simple",
+      "--json <file>",
+      "--operating-system linux",
+      "--python-version 38",
+      "--specifier zipp~=3.8.0"
+    ],
+    "notice": "Dependency tree generated with python-inspector.\npython-inspector is a free software tool from nexB Inc. and others.\nVisit https://github.com/aboutcode-org/python-inspector/ for support and download.",
+    "warnings": [],
+    "errors": []
+  },
+  "files": [],
+  "packages": [
+    {
+      "type": "pypi",
+      "namespace": null,
+      "name": "zipp",
+      "version": "3.8.1",
+      "qualifiers": {},
+      "subpath": null,
+      "primary_language": "Python",
+      "description": "Backport of pathlib-compatible object wrapper for zip files\n.. image:: https://img.shields.io/pypi/v/zipp.svg\n   :target: `PyPI link`_\n\n.. image:: https://img.shields.io/pypi/pyversions/zipp.svg\n   :target: `PyPI link`_\n\n.. _PyPI link: https://pypi.org/project/zipp\n\n.. image:: https://github.com/jaraco/zipp/workflows/tests/badge.svg\n   :target: https://github.com/jaraco/zipp/actions?query=workflow%3A%22tests%22\n   :alt: tests\n\n.. image:: https://img.shields.io/badge/code%20style-black-000000.svg\n   :target: https://github.com/psf/black\n   :alt: Code style: Black\n\n.. .. image:: https://readthedocs.org/projects/skeleton/badge/?version=latest\n..    :target: https://skeleton.readthedocs.io/en/latest/?badge=latest\n\n.. image:: https://img.shields.io/badge/skeleton-2022-informational\n   :target: https://blog.jaraco.com/skeleton\n\n.. image:: https://tidelift.com/badges/package/pypi/zipp\n   :target: https://tidelift.com/subscription/pkg/pypi-zipp?utm_source=pypi-zipp&utm_medium=readme\n\n\nA pathlib-compatible Zipfile object wrapper. Official backport of the standard library\n`Path object <https://docs.python.org/3.8/library/zipfile.html#path-objects>`_.\n\n\nCompatibility\n=============\n\nNew features are introduced in this third-party library and later merged\ninto CPython. The following table indicates which versions of this library\nwere contributed to different versions in the standard library:\n\n.. list-table::\n   :header-rows: 1\n\n   * - zipp\n     - stdlib\n   * - 3.5\n     - 3.11\n   * - 3.3\n     - 3.9\n   * - 1.0\n     - 3.8\n\n\nUsage\n=====\n\nUse ``zipp.Path`` in place of ``zipfile.Path`` on any Python.\n\nFor Enterprise\n==============\n\nAvailable as part of the Tidelift Subscription.\n\nThis project and the maintainers of thousands of other packages are working with Tidelift to deliver one enterprise subscription that covers all of the open source you use.\n\n`Learn more <https://tidelift.com/subscription/pkg/pypi-zipp?utm_source=pypi-zipp&utm_medium=referral&utm_campaign=github>`_.\n\nSecurity Contact\n================\n\nTo report a security vulnerability, please use the\n`Tidelift security contact <https://tidelift.com/security>`_.\nTidelift will coordinate the fix and disclosure.",
+      "release_date": "2022-07-12T14:21:20",
+      "parties": [
+        {
+          "type": "person",
+          "role": "author",
+          "name": "Jason R. Coombs",
+          "email": "[email protected]",
+          "url": null
+        }
+      ],
+      "keywords": [
+        "Development Status :: 5 - Production/Stable",
+        "Intended Audience :: Developers",
+        "Programming Language :: Python :: 3",
+        "Programming Language :: Python :: 3 :: Only"
+      ],
+      "homepage_url": "https://github.com/jaraco/zipp",
+      "download_url": "https://files.pythonhosted.org/packages/f0/36/639d6742bcc3ffdce8b85c31d79fcfae7bb04b95f0e5c4c6f8b206a038cc/zipp-3.8.1-py3-none-any.whl",
+      "size": 5645,
+      "sha1": null,
+      "md5": "300aa262796e7ebfb57b4d6731821c29",
+      "sha256": "47c40d7fe183a6f21403a199b3e4192cca5774656965b0a4988ad2f8feb5f009",
+      "sha512": null,
+      "bug_tracking_url": null,
+      "code_view_url": null,
+      "vcs_url": null,
+      "copyright": null,
+      "license_expression": null,
+      "declared_license": {
+        "classifiers": [
+          "License :: OSI Approved :: MIT License"
+        ]
+      },
+      "notice_text": null,
+      "source_packages": [],
+      "file_references": [],
+      "extra_data": {},
+      "dependencies": [],
+      "repository_homepage_url": null,
+      "repository_download_url": null,
+      "api_data_url": "https://pypi.org/pypi/zipp/3.8.1/json",
+      "datasource_id": null,
+      "purl": "pkg:pypi/[email protected]"
+    }
+  ],
+  "resolved_dependencies_graph": [
+    {
+      "package": "pkg:pypi/[email protected]",
+      "dependencies": []
+    }
+  ]
+}

tests/test_cli.py

@@ -228,7 +228,7 @@ def test_cli_with_single_env_var_index_url_except_pypi_simple():
 
 @pytest.mark.online
 def test_cli_with_multiple_env_var_index_url_and_tilde_req():
-    expected_file = test_env.get_test_loc("tilde_req-expected.json", must_exist=False)
+    expected_file = test_env.get_test_loc("tilde_req-expected-env.json", must_exist=False)
     specifier = "zipp~=3.8.0"
     os.environ[
         "PYINSP_INDEX_URL"
@@ -702,9 +702,8 @@ def run_cli(
     if "--generic-paths" not in options:
         options.append("--generic-paths")
 
-    pyinsp_root_dir = dirname(dirname(__file__))
-
-    py_cmd = "python-inspector"
+    root_dir = dirname(dirname(__file__))
+    py_cmd = os.path.abspath(os.path.join(root_dir, "venv", "bin", "python-inspector"))
     rc, stdout, stderr = execute(
         cmd_loc=py_cmd,
         args=options,
@@ -716,7 +715,7 @@ def run_cli(
         time.sleep(1)
         if "--verbose" not in options:
             options.append("--verbose")
-        result = rc, stdout, stderr = execute(
+        rc, stdout, stderr = execute(
             cmd_loc=py_cmd,
             args=options,
             env=env,
@@ -742,41 +741,3 @@ def run_cli(
 def get_opts(options):
     opts = [o if isinstance(o, str) else repr(o) for o in options]
     return " ".join(opts)
-
-
-def run_click(
-    options,
-    cli=resolve_dependencies,
-    expected_rc=0,
-    env=None,
-    get_env=True,
-):
-    """
-    Run a command line resolution. Return a click.testing.Result object.
-    """
-
-    if not env:
-        env = dict(os.environ)
-
-    runner = CliRunner()
-    if get_env:
-        options = append_os_and_pyver_options(options)
-
-    if "--generic-paths" not in options:
-        options.append("--generic-paths")
-
-    result = runner.invoke(cli, options, catch_exceptions=False, env=env)
-
-    if result.exit_code != expected_rc:
-        output = result.output
-        opts = " ".join(options)
-        if result.exit_code != expected_rc:
-            error = f"""
-    Failure to run:
-    rc: {result.exit_code}
-    python-inspector {opts}
-    output:
-    {output}
-    """
-            assert result.exit_code == expected_rc, error
-    return result