Dqt improvements

[marandmart]

Brief summary of changes

1. Updated Next Steps component to be more visually understandable

Open (old)

Closed (old)

Open (updated)

Closed (updated)

2. Updated and Reordered Icons on Recent Queries Panel

• Updated execute query and share query with more standardly used icons

Previously

Updated

3. Increased amount of space allocated to the Field Selection / Selected Fields section

Previously

Updated

4. Made large amounts of text on Selected Fields / Field Selection section not break into horizontal scrolling

Previously

Updated

5. Removed field that was selected by default

• In the local development environment it was causing a bug when clicking the sync fields checkbox and was breaking the page. It is not happening in demo.loris.ca/dataquery.

6. Updated placement of UI elements

• Removed redundant labels
• Updated the sync field label to make easier the understanding of what it does
• Updated Available Fields label to Select a Field to make more clear what the user needs to do
• Hid the previously named Default Visits dropdown field until the user clicks the Sync visit selection checkbox
• Height limited the Sync Visits selection box with a scrollbar so it won't take too much space when there are too many visits available
• Updated search box look to make it more distinct from the other selection fields
• Changed search box and add all / remove all button placement to better group them near the available fields and make their relation clearer
• Updated selected field list item so that visual elements won't clash together under certain screen sizes or depending on the amount of text.
• Height limited the visit selection with a scrollbar within a selected field list item in the field list so it won't take too much vertical space when there are too many visits available

Previously

Updated

Link(s) to related issue(s)

558: https://github.com/aces/CBIGR/issues/558

[driusan]

Can you split this into different PRs so that they can be independently tested/reviewed/merged?

Some preliminary thoughts (using the same numbering you used above)

1. Does it collapse to the bottom now instead of the side? If so, looks good to me. If not, the arrows are pointing to the wrong place?
2. I don't understand your new icons. What is the play icon and what does the reply icon do? The reason the share icon is a globe is because it acts more as a "make globally public" than a "share" (with a specific person). I'm not sure what you mean by "Execute." There is a "reload query" button. It doesn't execute it.
3. Looks good in the screenshot to me.
4. Also looks good
5. @ridz1208 I'll let you answer that one.
6. Overall it looks good but the textbox doesn't search, it filters the currently selected category.

[ridz1208]

@marandmart
2. We have the LORIS meeting tomorrow at 11, can we bring these up there? I'm on the fence myself about each change (globe for me means languages, but it is tru that I have seen it used for "make public", I think I prefer play to the reload Icon on the other hand, so I'm in between I'd liek the opinion of the team)
6. I think the placements is a great improvement, for the wording I'd also like a very quick input from the science side.

As for 5, that wa sa recent addition to the DQT because (my understanding) when a query is run it runs on all participants, and what happens is if 10 participants have data for the fields selected, we see these 10 with data and a bunch of fully empty rows. The reason we added the auto select for the ID is because its much more communicative to the user that the reason we see empty rows is that there is no data for these participants (I can give you a demo of what I mean). I dont mind an alternate approach as long as it is clear why we see hundreds of row with fully empty data.

I think the 1 change that should beundone for sure from here is #5 (to be discussed separately) as for the others, if @driusan wants them split, its his call but IF you are able to show very quickly tomorrow at the loris meeting what the overall looks like before its broken apart I think it would be good.

[charliehenrib]

@marandmart could you also modify the default visit field box to keep it a certain size and that we scroll within that box to modify the visit select, rather than having it change everytime you select a new instrument?

[ridz1208]

@charliehenrib

@driusan asked Mario to split apart the PR into multiple smaller ones so I think new requests can come as issues so Mario can deal with them one by one.

[marandmart]

@driusan @ridz1208 @charliehenrib
Here are the broken down PRs:
Item 1: #10159
Item 2: #10160
Items 3 & 4: #10161
Item 6: #10162

Should I close this one?