Skip to content

Commit 5dc8cf1

Browse files
committed
Remove shell-quote library from CDS extractor
Removes shell-quote as a dependency of the CDS extractor and implements alternative approaches to sanitizing the data sources that had previously been sanitized via the `quote` function of the shell-quote library, which causes a code scanning alert when included in the all-in-one `cds-extractor.bundle.js` file.
1 parent 19a17cf commit 5dc8cf1

File tree

12 files changed

+289
-388
lines changed

12 files changed

+289
-388
lines changed

.github/workflows/cds-extractor-dist-bundle.yml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,11 @@ jobs:
3636
working-directory: extractors/cds/tools
3737
run: npm run lint
3838

39-
- name: Run TS code unit tests
39+
- name: Run TS code unit tests with coverage report
4040
working-directory: extractors/cds/tools
41-
run: npm run test
41+
run: npm run test:coverage
4242

43-
- name: Compile TS code to create minified JS bundle
44-
working-directory: extractors/cds/tools
45-
run: npm run bundle
46-
47-
- name: Validate JS bundle
43+
- name: Build and validate the CDS extractor bundle
4844
working-directory: extractors/cds/tools
4945
run: npm run bundle:validate
5046

0 commit comments

Comments
 (0)