-
Couldn't load subscription status.
- Fork 39
test: add global gaze fixtures #1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
|
great idea, I also thought of that a while ago, thank you for tackling the issue. initial feedback/thought: since these are not directly tests, maybe have another repository like |
|
I'm not sure that I understand. fixtures are a very common part of test suites. fixtures should be tested though. The way I implemented this and imported in What I really wouldn't like is creating another repository just for testing. Can you provide a link to repository where your idea is implemented? |
|
Ah thank you for the comment, now I understand what you mean. This isn't a separate repository, it's a dedicated module. But as a side note: the I also thought about that originally as this is done in some packages, but currently I don't see much benefit to add this to the user API. If done bad, we would need to add I guess it makes sense in cases, where users extend the original package, so providing users with fixtures can make sense. For example in polars you can extend the api, so having fixtures available in a testing module is quite nice. It will take some time until this will be finished, so we'll have some time to discuss this further. Something like this could be better as it allows for more parametrizing: import pytest
@pytest.fixture()
def argument_printer():
def _foo(*args, **kwargs):
return (args, kwargs)
return _foo |
WIP
required by:
requires:
DatasetDefinitionto gaze init and io #1004