Skip to content

Conversation

@Alba10
Copy link
Collaborator

@Alba10 Alba10 commented Aug 21, 2025

Description

This PR introduces a parser for the data files generated from Psychopy for the Pupil Core device. Adding support for Pupil Core extends compatibility to a wider range of experiments.

Implemented changes

  • Added from_psychopy_csv() method to parse the data file generated from Psychopy.
  • Added a psychopy_example.csv data file.
  • Integrated a unit test with a sample dataset.

How Has This Been Tested?

  • psychopy_test.py

Type of change

Remove irrelevant items:

  • New functionality

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@github-actions github-actions bot added the enhancement New feature or request label Aug 21, 2025
@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.77%. Comparing base (40ff425) to head (f2f004e).
⚠️ Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
src/pymovements/gaze/io.py 50.00% 5 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main    #1271      +/-   ##
===========================================
- Coverage   100.00%   99.77%   -0.23%     
===========================================
  Files          104      104              
  Lines         4451     4533      +82     
  Branches       769      792      +23     
===========================================
+ Hits          4451     4523      +72     
- Misses           0        5       +5     
- Partials         0        5       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkrako
Copy link
Member

dkrako commented Oct 9, 2025

hi @Alba10 sorry for having kept you waiting so long. I needed to think about how to handle this feature.

After some consideration I think the contribution would fit the form of a tutorial notebook best.

There you could detail what you need to do in psychopy to get the csvs and how to use pymovements.gaze.from_csv() to load these files. A dedicated pymovements.gaze.from_psychopy_csv() wouldn't be necessary then.

Would you mind to prepare a first draft for such a jupyter notebook tutorial? It doesn't need to have many details, but it should include how you created the data files and how you specified the columns in psychopy and pymovements.gaze.from_csv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants