Skip to content

Commit 11ff852

Browse files
committed
Suppress all warnings for Metal compiler.
After going through cross-compilation the warnings don't really give much value as they can't be associated back to the original source. Updated glslang and SPIRV-Cross. Incremented version to 1.6.1.
1 parent 0d743af commit 11ff852

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ endif()
8181

8282
set(MSL_MAJOR_VERSION 1)
8383
set(MSL_MINOR_VERSION 6)
84-
set(MSL_PATCH_VERSION 0)
84+
set(MSL_PATCH_VERSION 1)
8585
set(MSL_VERSION ${MSL_MAJOR_VERSION}.${MSL_MINOR_VERSION}.${MSL_PATCH_VERSION})
8686

8787
set(MSL_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})

Compile/glslang

Submodule glslang updated 819 files

Compile/src/TargetMetal.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -300,10 +300,9 @@ bool TargetMetal::compileMetal(std::vector<std::uint8_t>& data, Output& output,
300300
if (!getStripDebug())
301301
extraOptions += " -gline-tables-only -MO";
302302

303-
// Optimized code sometimes creates unused float3 constants.
304-
// TODO: Check if future versions of SPIRV-Tools no longer cause this to happen.
305-
if (getOptimize() == Optimize::Full)
306-
extraOptions += " -Wno-unused-const-variable";
303+
// The output sometimes contains warnings that we can't control or make sense of in the final
304+
// generated output.
305+
extraOptions += " -w";
307306

308307
ExecuteCommand compile(".metal");
309308
compile.getInput().write(metal.data(), metal.size());

0 commit comments

Comments
 (0)