Added a portrait version #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llewelld
approved these changes
Nov 18, 2025
llewelld
left a comment
llewelld
left a comment
There was a problem hiding this comment.
This is a helpful addition. Both the coding style and the resulting page complements the existing portrait version. There are minimal differences between the example code. At this stage, after lingering here for 7 years, I'd argue that merging it in and making any further changes from there would be preferable to requesting changes and blocking the merge.
Below is a comparison of the two example outputs.
I think this should be merged in with no changes required.
|
Any objections to merging this in @martintoreilly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a portrait version of the poster