feat: add noElectronStart CLI option to the dev command
#578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikian
force-pushed
the
feat/dev-noElectronStart-option
branch
from
402b22f to
05fd155
Compare
erikian
force-pushed
the
feat/dev-noElectronStart-option
branch
from
05fd155 to
03936a3
Compare
|
@alex8088 friendly bump 🙂 |
|
Hey @alex8088, let me know if there's anything I can do to help move this PR along. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds an option to not start the Electron app after the dev server is up.
Additional context
The main motivation is being able to run Playwright tests faster; this would make it possible to use
electron-viteto run the dev server and configure Playwright to run in development mode using that server, instead of having to bundle the entire project beforehand (which takes too long if you just want to run a one-off test to validate the code you're currently working on).What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).