chore: bump package:lints & resolve warnings

Author: alexmercerind

ffi/example.dart

@@ -89,5 +89,5 @@ String get dynamicLibraryPath {
       .split('/')
       .sublist(0, Platform.script.path.split('/').length - 1)
       .join('/');
-  return directory + '/' + 'dart_vlc.so';
+  return '$directory/dart_vlc.so';
 }

ffi/lib/src/device.dart

@@ -18,11 +18,15 @@ class Devices {
   /// Gets [List] of all available playback [Device].
   static List<Device> get all {
     List<Device> devices = <Device>[];
-    final _devices = DevicesFFI.all(devices);
-    for (int i = 0; i < _devices.ref.size; i++) {
-      final _device = _devices.ref.devices.elementAt(i);
-      devices.add(Device(
-          _device.ref.id.toDartString(), _device.ref.name.toDartString()));
+    final devicesPtr = DevicesFFI.all(devices);
+    for (int i = 0; i < devicesPtr.ref.size; i++) {
+      final devicePtr = devicesPtr.ref.devices.elementAt(i);
+      devices.add(
+        Device(
+          devicePtr.ref.id.toDartString(),
+          devicePtr.ref.name.toDartString(),
+        ),
+      );
     }
     return devices;
   }

ffi/lib/src/equalizer.dart

@@ -32,32 +32,32 @@ class Equalizer {
   /// Creates a default [Equalizer] instance with all values set to `0.0`.
   factory Equalizer.createEmpty() {
     Equalizer equalizer = Equalizer._();
-    final _equalizer = EqualizerFFI.createEmpty(
+    final equalizerPtr = EqualizerFFI.createEmpty(
       equalizer,
     );
-    equalizer.id = _equalizer.ref.id;
+    equalizer.id = equalizerPtr.ref.id;
     equalizer.preAmp = equalizer.preAmp;
     equalizer.mode = null;
     equalizer.bandAmps = {};
-    for (int i = 0; i < _equalizer.ref.size; i++) {
-      equalizer.bandAmps[_equalizer.ref.bands[i]] = _equalizer.ref.amps[i];
+    for (int i = 0; i < equalizerPtr.ref.size; i++) {
+      equalizer.bandAmps[equalizerPtr.ref.bands[i]] = equalizerPtr.ref.amps[i];
     }
     return equalizer;
   }
 
   /// Creates an [Equalizer] instance with any preset from [EqualizerMode].
   factory Equalizer.createMode(EqualizerMode mode) {
     Equalizer equalizer = Equalizer._();
-    final _equalizer = EqualizerFFI.createMode(
+    final equalizerPtr = EqualizerFFI.createMode(
       equalizer,
       mode.index,
     );
-    equalizer.id = _equalizer.ref.id;
+    equalizer.id = equalizerPtr.ref.id;
     equalizer.preAmp = equalizer.preAmp;
     equalizer.mode = mode;
     equalizer.bandAmps = {};
-    for (int i = 0; i < _equalizer.ref.size; i++) {
-      equalizer.bandAmps[_equalizer.ref.bands[i]] = _equalizer.ref.amps[i];
+    for (int i = 0; i < equalizerPtr.ref.size; i++) {
+      equalizer.bandAmps[equalizerPtr.ref.bands[i]] = equalizerPtr.ref.amps[i];
     }
     return equalizer;
   }

ffi/pubspec.yaml

@@ -13,4 +13,4 @@ dependencies:
   path: ^1.7.0
 
 dev_dependencies:
-  lints: ^1.0.0
+  lints: ^2.0.1

lib/src/widgets/controls.dart

@@ -363,10 +363,10 @@ class VolumeControl extends StatefulWidget {
   }) : super(key: key);
 
   @override
-  _VolumeControlState createState() => _VolumeControlState();
+  VolumeControlState createState() => VolumeControlState();
 }
 
-class _VolumeControlState extends State<VolumeControl> {
+class VolumeControlState extends State<VolumeControl> {
   double volume = 0.5;
   bool _showVolume = false;
   double unmutedVolume = 0.5;

lib/src/widgets/video.dart

@@ -173,10 +173,10 @@ class Video extends StatefulWidget {
   final Color fillColor;
 
   @override
-  _VideoStateBase createState() => _VideoStateTexture();
+  VideoStateBase createState() => VideoStateTexture();
 }
 
-abstract class _VideoStateBase extends State<Video>
+abstract class VideoStateBase extends State<Video>
     with AutomaticKeepAliveClientMixin {
   GlobalKey<ControlState> controlKey = GlobalKey<ControlState>();
 
@@ -221,7 +221,7 @@ abstract class _VideoStateBase extends State<Video>
 }
 
 /// Texture based Video playback.
-class _VideoStateTexture extends _VideoStateBase {
+class VideoStateTexture extends VideoStateBase {
   StreamSubscription? _videoDimensionsSubscription;
   double? _videoWidth;
   double? _videoHeight;
@@ -285,7 +285,7 @@ class _VideoStateTexture extends _VideoStateBase {
 
 /// NativePorts & decodeImageFromPixels based video playback.
 // ignore: unused_element
-class _VideoStateFallback extends _VideoStateBase {
+class VideoStateFallback extends VideoStateBase {
   Widget? videoFrameRawImage;
 
   Future<RawImage> getVideoFrameRawImage(VideoFrame videoFrame) async {
@@ -295,7 +295,7 @@ class _VideoStateFallback extends _VideoStateBase {
         videoFrame.videoWidth,
         videoFrame.videoHeight,
         ui.PixelFormat.rgba8888,
-        (ui.Image _image) => imageCompleter.complete(_image),
+        (ui.Image i) => imageCompleter.complete(i),
         rowBytes: 4 * videoFrame.videoWidth);
     ui.Image image = await imageCompleter.future;
 

pubspec.yaml

@@ -18,7 +18,7 @@ dependencies:
   audio_video_progress_bar: ^0.11.0
 
 dev_dependencies:
-  lints: ^1.0.0
+  lints: ^2.0.1
 
 # REMOVE THIS BEFORE PUBLISHING ON pub.dev.
 dependency_overrides: