Merge pull request #1852 from algolia/fix/MAGE-1455-missing-price-values-3.16

MAGE-1455 Handle missing price values 3.16

Author: damcou

CHANGELOG.md

@@ -1,5 +1,10 @@
 # CHANGE LOG
 
+## 3.16.2
+
+### Bug fixes
+- Fixed issue where missing pricing keys were not handled gracefully in the Autocomplete product template
+
 ## 3.16.1
 
 ### Updates

composer.json

@@ -3,7 +3,7 @@
   "description": "Algolia Search & Discovery extension for Magento 2",
   "type": "magento2-module",
   "license": ["MIT"],
-  "version": "3.16.1",
+  "version": "3.16.2-dev",
   "require": {
     "php": "~8.2|~8.3|~8.4",
     "magento/framework": "~103.0",

etc/module.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-    <module name="Algolia_AlgoliaSearch" setup_version="3.16.1">
+    <module name="Algolia_AlgoliaSearch" setup_version="3.16.2-dev">
         <sequence>
             <module name="Magento_Theme"/>
             <module name="Magento_Backend"/>

view/frontend/web/js/template/autocomplete/products.js

@@ -45,40 +45,40 @@ define([], function () {
 
         getColorHtml: function(item, components, html) {
             const highlight = this.safeHighlight(components, item, "color");
-            
-            return highlight 
+
+            return highlight
                 ? html`<span class="color">color: ${highlight}</span>`
                 : "";
         },
 
         getCategoriesHtml: function(item, components, html) {
             const highlight = this.safeHighlight(components, item, "categories_without_path", false);
 
-            return highlight 
+            return highlight
                 ? html`<span>in ${highlight}</span>`
                 : "";
         },
 
         getOriginalPriceHtml: (item, html, priceGroup) => {
-            if (item['price'][algoliaConfig.currencyCode][priceGroup + '_original_formated'] == null) return "";
+            if (item['price']?.[algoliaConfig.currencyCode]?.[priceGroup + '_original_formated'] == null) return "";
 
             return html`<span class="before_special"> ${item['price'][algoliaConfig.currencyCode][priceGroup + '_original_formated']} </span>`;
         },
 
         getTierPriceHtml: (item, html, priceGroup) => {
-            if (item['price'][algoliaConfig.currencyCode][priceGroup + '_tier_formated'] == null) return "";
+            if (item['price']?.[algoliaConfig.currencyCode]?.[priceGroup + '_tier_formated'] == null) return "";
 
             return html`<span class="tier_price"> As low as <span class="tier_value">${item['price'][algoliaConfig.currencyCode][priceGroup + '_tier_formated']}</span></span>`;
         },
 
         getPricingHtml: function(item, html) {
-            if (item['price'] == undefined) return "";
+            if (item['price'] == null) return "";
 
             const priceGroup =  algoliaConfig.priceGroup || 'default';
 
             return html `<div className="algoliasearch-autocomplete-price">
-                <span className="after_special ${item['price'][algoliaConfig.currencyCode][priceGroup + '_original_formated'] != null ? 'promotion' : ''}">
-                    ${item['price'][algoliaConfig.currencyCode][priceGroup + '_formated']}
+                <span className="after_special ${item['price']?.[algoliaConfig.currencyCode]?.[priceGroup + '_original_formated'] != null ? 'promotion' : ''}">
+                    ${item['price']?.[algoliaConfig.currencyCode]?.[priceGroup + '_formated']}
                 </span>
                 ${this.getOriginalPriceHtml(item, html, priceGroup)}
 
@@ -87,7 +87,7 @@ define([], function () {
         },
 
         getFooterSearchCategoryLinks: (html, resultDetails) => {
-            if (resultDetails.allCategories == undefined || resultDetails.allCategories.length === 0) return "";
+            if (resultDetails.allCategories == null || resultDetails.allCategories.length === 0) return "";
 
             return html ` ${algoliaConfig.translations.orIn}
                 ${resultDetails.allCategories.map((list, index) =>