allow depending on libiconv or win_iconv

Author: Techatrix

.github/workflows/ci.yaml

@@ -33,9 +33,4 @@ jobs:
         run: zig fmt --ast-check --check .
 
       - name: Build
-        if: matrix.os != 'windows-latest'
         run: zig build --summary all
-
-      - name: Build (windows)
-        if: matrix.os == 'windows-latest'
-        run: zig build -Diconv=false --summary all

build.zig

@@ -193,10 +193,44 @@ pub fn build(b: *std.Build) void {
     if (history) xml_lib.root_module.linkSystemLibrary("history", .{});
     if (lzma) xml_lib.root_module.linkSystemLibrary("lzma", .{});
     if (icu) xml_lib.root_module.linkSystemLibrary("icu-i18n", .{});
-    if (iconv and target.result.os.tag == .windows) xml_lib.root_module.linkSystemLibrary("iconv", .{});
     if (target.result.os.tag == .windows) xml_lib.root_module.linkSystemLibrary("bcrypt", .{});
     if (http and target.result.os.tag == .windows) xml_lib.root_module.linkSystemLibrary("ws2_32", .{});
 
+    if (iconv) {
+        if (b.systemIntegrationOption("iconv", .{})) {
+            xml_lib.root_module.linkSystemLibrary("iconv", .{});
+        } else {
+            const IconvImpl = enum { libc, libiconv, win_iconv };
+            const impl: IconvImpl = b.option(
+                IconvImpl,
+                "iconv-impl",
+                "Set the iconv implementation (default=libc except for win_iconv on windows)",
+            ) orelse switch (target.result.os.tag) {
+                .windows => .win_iconv,
+                else => .libc,
+            };
+            switch (impl) {
+                .libc => {},
+                .libiconv => {
+                    if (b.lazyDependency("libiconv", .{
+                        .target = target,
+                        .optimize = optimize,
+                    })) |libiconv_dependency| {
+                        xml_lib.root_module.linkLibrary(libiconv_dependency.artifact("z"));
+                    }
+                },
+                .win_iconv => {
+                    if (b.lazyDependency("win_iconv", .{
+                        .target = target,
+                        .optimize = optimize,
+                    })) |win_iconv_dependency| {
+                        xml_lib.root_module.linkLibrary(win_iconv_dependency.artifact("iconv"));
+                    }
+                },
+            }
+        }
+    }
+
     if (zlib) {
         if (b.systemIntegrationOption("zlib", .{})) {
             xml_lib.root_module.linkSystemLibrary("zlib", .{});

build.zig.zon

@@ -12,6 +12,16 @@
             .hash = "zlib-1.3.1-ZZQ7lVgMAACwO4nUUd8GLhsuQ5JQq_VAhlEiENJTUv6h",
             .lazy = true,
         },
+        .libiconv = .{
+            .url = "git+https://github.com/allyourcodebase/libiconv.git#9def4c8a1743380e85bcedb80f2c15b455e236f3",
+            .hash = "libiconv-1.18.0-p9sJwWnqAACzVYeWgXB5r5lOQ74XwTPlptixV0JPRO28",
+            .lazy = true,
+        },
+        .win_iconv = .{
+            .url = "git+https://github.com/allyourcodebase/win-iconv.git#497c381e41437856527b7a00b66e75af3f1f7dcc",
+            .hash = "win_iconv-0.0.10--19NP7MRAAD3CC0z2Jp2YTy649Q724cYYaR9uL7v7NCh",
+            .lazy = true,
+        },
     },
     .paths = .{
         "build.zig",