Fix SQLite migrations table insert statements due to incorrect row offset and improve tests for insert statements

Author: bstanley-pec

composer.json

@@ -24,6 +24,7 @@
         }
     ],
     "require": {
+        "ext-mbstring": "*",
         "php": "~7.3|~8.0.0|~8.1.0|~8.2.0|~8.3.0|~8.4.0",
         "laravel/framework": "^8.0|^9.0|^10.0|^11.0|^12"
     },

src/Commands/MigrateDumpCommand.php

@@ -442,9 +442,16 @@ private static function sqliteSchemaDump(array $db_config, string $schema_sql_pa
             }
 
             if ($migrationsTable === $table) {
-                $insert_rows = array_slice($output, 4, -1);
+                $insert_rows = array_filter(
+                    $output,
+                    function ($line) {
+                        return 0 !== preg_match('/^\s*(INSERT INTO\s)/iu', $line)
+                            && 0 < mb_strlen($line);
+                    }
+                );
+
                 $sorted = self::reorderMigrationRows($insert_rows);
-                array_splice($output, 4, -1, $sorted);
+                array_splice($output, array_key_first($insert_rows), -1, $sorted);
             }
 
             file_put_contents(

tests/Mysql/MigrateDumpTest.php

@@ -17,7 +17,8 @@ public function test_handle()
         $this->assertFileExists($this->schemaSqlPath);
         $result_sql = file_get_contents($this->schemaSqlPath);
         $this->assertMatchesRegularExpression("/CREATE TABLE [\`\"]{$this->dbPrefix}test_ms[\`\"]/", $result_sql);
-        $this->assertMatchesRegularExpression("/INSERT INTO [\`\"]{$this->dbPrefix}migrations[\`\"]/", $result_sql);
+        $this->assertStringContainsString("INSERT INTO `{$this->dbPrefix}migrations` VALUES (1,'0000_00_00_000000_create_test_tables',0);", $result_sql);
+        $this->assertStringContainsString("INSERT INTO `{$this->dbPrefix}migrations` VALUES (2,'0000_00_00_000001_second_migration_for_testing',0);", $result_sql);
         $this->assertStringNotContainsString(' AUTO_INCREMENT=', $result_sql);
         $last_character = mb_substr($result_sql, -1);
         $this->assertMatchesRegularExpression("/[\r\n]\z/mu", $last_character);

tests/Postgresql/MigrateDumpTest.php

@@ -18,7 +18,8 @@ public function test_handle()
         $this->assertFileExists($this->schemaSqlPath);
         $result_sql = file_get_contents($this->schemaSqlPath);
         $this->assertMatchesRegularExpression("/CREATE TABLE (public\.)?{$this->dbPrefix}test_ms /", $result_sql);
-        $this->assertMatchesRegularExpression("/INSERT INTO (public\.)?{$this->dbPrefix}migrations /", $result_sql);
+        $this->assertStringContainsString("INSERT INTO public.{$this->dbPrefix}migrations VALUES (1,'0000_00_00_000000_create_test_tables',0);", $result_sql);
+        $this->assertStringContainsString("INSERT INTO public.{$this->dbPrefix}migrations VALUES (2,'0000_00_00_000001_second_migration_for_testing',0);", $result_sql);
         $last_character = mb_substr($result_sql, -1);
         $this->assertMatchesRegularExpression("/[\r\n]\z/mu", $last_character);
     }

tests/Sqlite/MigrateDumpTest.php

@@ -14,7 +14,8 @@ public function test_handle()
         $this->assertFileExists($this->schemaSqlPath);
         $result_sql = file_get_contents($this->schemaSqlPath);
         $this->assertMatchesRegularExpression("/CREATE TABLE( IF NOT EXISTS)? \"{$this->dbPrefix}test_ms\" /", $result_sql);
-        $this->assertMatchesRegularExpression("/INSERT INTO \"?{$this->dbPrefix}migrations\"? /", $result_sql);
+        $this->assertStringContainsString("INSERT INTO {$this->dbPrefix}migrations VALUES(1,'0000_00_00_000000_create_test_tables',0);", $result_sql);
+        $this->assertStringContainsString("INSERT INTO {$this->dbPrefix}migrations VALUES(2,'0000_00_00_000001_second_migration_for_testing',0);", $result_sql);
         $last_character = mb_substr($result_sql, -1);
         $this->assertMatchesRegularExpression("/[\r\n]\z/mu", $last_character);
     }

tests/TestCase.php

@@ -65,5 +65,9 @@ protected function createTestTablesWithoutMigrate() : void
             'migration' => '0000_00_00_000000_create_test_tables',
             'batch' => 1,
         ]);
+        \DB::table('migrations')->insert([
+            'migration' => '0000_00_00_000001_second_migration_for_testing',
+            'batch' => 1,
+        ]);
     }
 }

tests/migrations/setup/0000_00_00_000001_second_migration_for_testing.php

@@ -0,0 +1,14 @@
+<?php
+
+class SecondMigrationForTesting extends \Illuminate\Database\Migrations\Migration
+{
+    public function up()
+    {
+        // this migration just needs to exist to confirm migration table insert statements
+    }
+
+    public function down()
+    {
+        //
+    }
+}