Skip to content

Conversation

@Shimul22
Copy link

Added a new option: setAsMaxYear (true or false), to decide whether user wants to add one/more years after current year or not

Added a new option: setAsMaxYear (true or false), to decide whether user wants to add one/more years after current year or not
@Shimul22
Copy link
Author

Shimul22 commented Apr 29, 2019

If setAsMaxYear: true --> then the current year will be treated as the last year/max year (in the dropdown)

If setAsMaxYear: false (or not included) --> Then numberYears will be added after current year

This will solve #1161

@DanielRuf
Copy link
Contributor

Hi @Shimul22,

Thanks for the PR.

Please update the title and commit message and provide some tests if possible.

Can you add this for v5? v3 is not actively developed anymore.

@Shimul22
Copy link
Author

Shimul22 commented Apr 29, 2019

@DanielRuf

Please update the title

Can you tell me what do mean by the title?

Can you add this for v5? v3 is not actively developed anymore

Version v5 means future origin?

@DanielRuf
Copy link
Contributor

Update picker.date.js

This title / message is not sufficient. Please change it do describe your changes. See the other PRs.

@DanielRuf
Copy link
Contributor

Version v5 means future origin?

Exactly. This is a full rewrite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants