Madura DPD #3016
Madura DPD #3016
Conversation
Add Orx to Tx mapping setting functionality. Signed-off-by: George Mois <[email protected]>
Add external path delay initial calibration selection. Signed-off-by: George Mois <[email protected]>
Add an IIO attribute that allows changing the calibration mask. Signed-off-by: George Mois <[email protected]>
danmois
requested review from
CiprianRegus,
amiclaus,
btogorean,
buha,
chegbeli,
dbogdan,
machschmitt,
mhennerich,
nunojsa and
rbolboac
as code owners
There was a problem hiding this comment.
looked into the ci output to check sanity. the two new warnings seems to be valid, I highlighted with comments.
There are extra warnings outside touched lines, that would be nice to progressively resolve.
In the files changed tab, action summary page, and log file, you can see the ci warnings
drivers/iio/adc/adrv902x/adrv9025.c
Outdated
|
|
||
| ret = sysfs_create_bin_file(&indio_dev->dev.kobj, &phy->bin); | ||
| if (ret < 0) | ||
| return ret; |
There was a problem hiding this comment.
From ci: shouldn't this go to the error de-initialization path?
There was a problem hiding this comment.
Yes it should, thank you! I will update the function.
There was a problem hiding this comment.
Also do not use the above function. Directly accessing a fundamental thing as kobjects from a driver is a very strong sign of something very odd. Use the device_create_bin_file() wrapper.
drivers/iio/adc/adrv902x/adrv9025.c
Outdated
|
|
||
| ret = sscanf(line, "%hhu %hhu %hhu %hhu %s", &i, &j, &k, &lut, coef); | ||
| if (ret != 5) | ||
| return ret; |
There was a problem hiding this comment.
From ci: this is never a error code.
There was a problem hiding this comment.
True. I wonder if an error message should be displayed before returning -EINVAL?
Add a bin_attribute for loading the data structure to hold Tx DPD Model initialization parameters, without floats. Signed-off-by: George Mois <[email protected]>
Add IIO attribute for selecting the target Tx channel for DPD. Signed-off-by: George Mois <[email protected]>
Add IIO attribute for resetting DPD. Signed-off-by: George Mois <[email protected]>
Add DEBUGF attribut for getting DPD status on each of the 4 Tx channels. Signed-off-by: George Mois <[email protected]>
Add tracking configuration settings. Signed-off-by: George Mois <[email protected]>
Add IIO attribute for enabling DPD. Signed-off-by: George Mois <[email protected]>
danmois
force-pushed
the
staging/madura_dpd
branch
from
ddd8c1a to
1457283
Compare
|
V2
|
PR Description
Add DPD functionality to the Madura driver.
PR Type
PR Checklist