Skip to content

Dagger @Module cleanup #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 11, 2025
Merged

Dagger @Module cleanup #53

merged 3 commits into from
Jul 11, 2025

Conversation

SimonMarquis
Copy link
Contributor

  • Replace unnecessary @Provides with @Binds
  • Add missing @Inject constructors
  • Lower visibility of classes and fields where modularization permits
  • Convert raw Context and @ApplicationContext usages with explicit Application

@SimonMarquis
Dagger @Module cleanup
25f7173 
- Replace unnecessary `@Provides` with `@Binds`
- Add missing `@Inject constructor`s
- Lower visibility of classes and fields where modularization permits
- Convert raw `Context` and `@ApplicationContext` usages with explicit `Application`
@tiwiz tiwiz requested a review from dturner July 7, 2025 13:39
dturner
dturner approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@dturner dturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @SimonMarquis :)

@dturner
Merge branch 'main' into dagger-module
62ff819 
* main: (56 commits)
  Move to LocalFileProvider rather than ImageGenerationRepository
  Change the shape to be the Material one instead
  Add fake to Android tests
  Fix naming
  Create Fake for testing
  Fix code review comments
  Add comments to clarify the logic
  Use ImageGenerationRepository to process the image dragged to Androidify
  Move DropBehaviour to be injected
  Add export services for instrumented tests too.
  Update README.md
  Fix build error for accessing token
  Remove local google-services.json file, and pull debug file down in build_and_test.yml workflow instead. Add to .gitignore
  Clean imports
  Enables Dropping an image into Androidify
  Update video player logic: now it pauses also when another window is occluding it (in multi-window mode)
  Update video player logic: now it pauses also when another window is occluding it (in multi-window mode)
  Revert the bot image desc change
  Revert the video semantics desc change
  Improve the layout of the footer buttons
  ...
@dturner
Copy link
Contributor

dturner commented Jul 8, 2025

@riggaroo The CI build is failing with Malformed root json at /home/runner/work/androidify/androidify/app/google-services.json

@dturner dturner requested a review from riggaroo July 8, 2025 16:04
@SimonMarquis
Copy link
Contributor Author

The DEBUG_GOOGLE_SERVICES_JSON_BASE64 secret on this repository is probably either empty or malformed.
I've configured a proper value in my own fork and the checks are both ✅ as you can see here:

@riggaroo
Copy link
Collaborator

This PR should hopefully fix this - #78 - its due to it being a fork with the author not having access to the secrets

@riggaroo riggaroo merged commit 1a5b720 into android:main Jul 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dturner dturner dturner approved these changes

@riggaroo riggaroo Awaiting requested review from riggaroo riggaroo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonMarquis @dturner @riggaroo